From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryder Lee Subject: Re: [PATCH] spi: mediatek: Use of_device_get_match_data() Date: Mon, 30 Apr 2018 15:26:36 +0800 Message-ID: <1525073196.21494.3.camel@mtkswgap22> References: <31f944ab8dfcc1d7b6f03b35657a2a34825b5246.1523347340.git.ryder.lee@mediatek.com> <94cba80f703be048666afde1ed53c15c3704c533.1523347340.git.ryder.lee@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Cc: Leilk Liu =?UTF-8?Q?=28=E5=88=98=E7=A3=8A=29?= , "linux-kernel@vger.kernel.org" , "linux-spi@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" To: Mark Brown Return-path: In-Reply-To: <94cba80f703be048666afde1ed53c15c3704c533.1523347340.git.ryder.lee@mediatek.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org Hi Mark, Is it okay with you? On Mon, 2018-04-16 at 10:33 +0800, Ryder Lee (李庚?V) wrote: > The usage of of_device_get_match_data() reduce the code size a bit. > > Also, the only way to call mtk_spi_probe() is to match an entry in > mtk_spi_of_match[], so of_id cannot be NULL. > > Signed-off-by: Ryder Lee > --- > drivers/spi/spi-mt65xx.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) >