From: Jaewon Kim <jaewon02.kim@gmail.com>
To: Mark Brown <broonie@kernel.org>, Jaewon Kim <jaewon02.kim@samsung.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] spi: dw: fix buffer end address
Date: Thu, 25 Oct 2018 00:37:17 +0900 [thread overview]
Message-ID: <1540395437-6623-1-git-send-email-jaewon02.kim@samsung.com> (raw)
Buffer address can be NULL, if user does not want to receive TX/RX data.
In this case, driver should not set the rx/tx_end value with len.
Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
---
drivers/spi/spi-dw.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-dw.c b/drivers/spi/spi-dw.c
index b705f2b..34e6fca 100644
--- a/drivers/spi/spi-dw.c
+++ b/drivers/spi/spi-dw.c
@@ -293,9 +293,13 @@ static int dw_spi_transfer_one(struct spi_controller *master,
dws->dma_mapped = 0;
dws->tx = (void *)transfer->tx_buf;
- dws->tx_end = dws->tx + transfer->len;
+ dws->tx_end = dws->tx;
+ if (dws->tx)
+ dws->tx_end += transfer->len;
dws->rx = transfer->rx_buf;
- dws->rx_end = dws->rx + transfer->len;
+ dws->rx_end = dws->rx;
+ if (dws->rx)
+ dws->rx_end += transfer->len;
dws->len = transfer->len;
spi_enable_chip(dws, 0);
--
2.7.4
next reply other threads:[~2018-10-24 15:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 15:37 Jaewon Kim [this message]
2018-10-29 16:35 ` [PATCH] spi: dw: fix buffer end address Jaewon Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1540395437-6623-1-git-send-email-jaewon02.kim@samsung.com \
--to=jaewon02.kim@gmail.com \
--cc=broonie@kernel.org \
--cc=jaewon02.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).