Re: [PATCH V4] spi: s3c64xx: Enable Word transfer

[Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

[CCing Sylwester, Andrzej and Lukasz]

On Thursday 07 of November 2013 14:52:36 Rajeshwari Birje wrote:
> Hi Mark Brown,
> 
> On Wed, Nov 6, 2013 at 1:51 PM, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> > On Wed, Nov 06, 2013 at 10:23:07AM +0530, Rajeshwari Birje wrote:
> >> On Thu, Oct 31, 2013 at 6:07 PM, Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 
wrote:
> >> > The driver as of today's linux-next does not seem to support word
> >> > transfers. Do you have some additional, out of tree patches that
> >> > add
> >> > such support?
> >> 
> >> Yes I set the bits_per_word to 32/16 in drivers/mtd/devices/m25p80.c
> >> m25p_probe function and the call spi_setup(spi).
> > 
> > This sound wrong.  If you just set bits per word then this should
> > result in data corruption on the bus since it should cause the words
> > written to the bus to be reordered.  Are you sure that the existing
> > driver isn't working correctly?
> 
> The reordering of the words is taken care by the Swap configuration
> (swap_cfg) register, which I have set for both 16 and 32 bits_per_word
> case. I have tested this patch and works fine for me and also has
> improved the timing performance.

This driver seems to have already worked fine with 32 bits per word,
using the s5c73m3 camera sensor, which uses SPI for firmware upload.

Sylwester, Andrzej or Lukasz: Can you confirm this?

Best regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html