From: Florian Fainelli <florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
To: Jonas Gorski <jogo-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Kevin Cernekee <cernekee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>,
Maxime Bizon <mbizon-MmRyKUhfbQ9GWvitb5QawA@public.gmane.org>
Subject: Re: [PATCH 00/12] spi/bcm63xx: various small cleanups and fixes
Date: Tue, 12 Mar 2013 00:20:33 +0100 [thread overview]
Message-ID: <1550045.lN4y9TcD08@bender> (raw)
In-Reply-To: <1363043627-23524-1-git-send-email-jogo-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
On Tuesday 12 March 2013 00:13:35 Jonas Gorski wrote:
> This patch series cleans up spi-bcm63xx and removes mostly redundant
> checks that are already done by the spi core system itself, and also
> adds some clock handling improvements. All in all nothing serious,
> just some corner cases.
>
> The only Patch I'm not 100% sure about is patch 7/12 ("check spi
> bits_per_word in spi_setup"), because I'm not sure if setup is the
> right place for that.
>
> For all we care the spi can claim what it wants as its bit_per_word
> as long as all transfers have it set to 8, so arguably we maybe
> shouldn't reject it then.
For the entire serie:
Acked-by: Florian Fainelli <florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
thanks Jonas!
--
Florian
------------------------------------------------------------------------------
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the
endpoint security space. For insight on selecting the right partner to
tackle endpoint security challenges, access the full report.
http://p.sf.net/sfu/symantec-dev2dev
prev parent reply other threads:[~2013-03-11 23:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 23:13 [PATCH 00/12] spi/bcm63xx: various small cleanups and fixes Jonas Gorski
[not found] ` <1363043627-23524-1-git-send-email-jogo-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2013-03-11 23:13 ` [PATCH 01/12] spi/bcm63xx: Remove unused variable Jonas Gorski
2013-03-11 23:13 ` [PATCH 02/12] spi/bcm63xx: don't disable non enabled clocks in probe error path Jonas Gorski
2013-03-11 23:13 ` [PATCH 03/12] spi/bcm63xx: properly prepare clocks before enabling them Jonas Gorski
2013-03-11 23:13 ` [PATCH 04/12] spi/bcm63xx: remove duplicated mode bits check Jonas Gorski
2013-03-11 23:13 ` [PATCH 05/12] spi/bcm63xx: remove unneeded debug message Jonas Gorski
2013-03-11 23:13 ` [PATCH 06/12] spi/bcm63xx: remove unused variable bs from bcm63xx_spi_setup Jonas Gorski
2013-03-11 23:13 ` [PATCH 07/12] spi/bcm63xx: check spi bits_per_word in spi_setup Jonas Gorski
2013-03-11 23:13 ` [PATCH 08/12] spi/bcm63xx: simplify bcm63xx_spi_check_transfer Jonas Gorski
2013-03-11 23:13 ` [PATCH 09/12] spi/bcm63xx: remove spi chip select validity check Jonas Gorski
2013-03-11 23:13 ` [PATCH 10/12] spi/bcm63xx: inline bcm63xx_spi_check_transfer Jonas Gorski
2013-03-11 23:13 ` [PATCH 11/12] spi/bcm63xx: inline hz usage in bcm63xx_spi_setup_transfer Jonas Gorski
2013-03-11 23:13 ` [PATCH 12/12] spi/bcm63xx: use devm_ioremap_resource() Jonas Gorski
2013-03-11 23:20 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1550045.lN4y9TcD08@bender \
--to=florian-p3rkhjxn3npafugrpc6u6w@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=cernekee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jogo-p3rKhJxN3npAfugRpC6u6w@public.gmane.org \
--cc=mbizon-MmRyKUhfbQ9GWvitb5QawA@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).