From: Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>
To: <broonie@kernel.org>, <bbrezillon@kernel.org>
Cc: <vigneshr@ti.com>, <linux-spi@vger.kernel.org>,
<dwmw2@infradead.org>, <marek.vasut@gmail.com>, <richard@nod.at>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<michal.simek@xilinx.com>, <nagasuresh12@gmail.com>,
Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>
Subject: [LINUX PATCH 2/3] spi: spi-mem: call spi_mem_default_supports_op() first
Date: Thu, 28 Mar 2019 16:46:24 +0530 [thread overview]
Message-ID: <1553771784-3364-1-git-send-email-naga.sureshkumar.relli@xilinx.com> (raw)
Call spi_mem_default_supports_op() first, before calling controller
specific ctlr->supports_op().
With this, controller drivers can drop checking the buswidths again.
Suggested-by: Vignesh Raghavendra <vigneshr@ti.com>
Signed-off-by: Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>
---
Details can be found at https://lkml.org/lkml/2019/3/1/183
---
drivers/spi/spi-mem.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-mem.c b/drivers/spi/spi-mem.c
index 5217a56..56aa158 100644
--- a/drivers/spi/spi-mem.c
+++ b/drivers/spi/spi-mem.c
@@ -189,11 +189,14 @@ static bool spi_mem_internal_supports_op(struct spi_mem *mem,
const struct spi_mem_op *op)
{
struct spi_controller *ctlr = mem->spi->controller;
+ bool ret;
+
+ ret = spi_mem_default_supports_op(mem, op);
if (ctlr->mem_ops && ctlr->mem_ops->supports_op)
- return ctlr->mem_ops->supports_op(mem, op);
+ ret = ctlr->mem_ops->supports_op(mem, op);
- return spi_mem_default_supports_op(mem, op);
+ return ret;
}
/**
--
2.7.4
next reply other threads:[~2019-03-28 11:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 11:16 Naga Sureshkumar Relli [this message]
2019-03-28 19:55 ` [LINUX PATCH 2/3] spi: spi-mem: call spi_mem_default_supports_op() first Boris Brezillon
2019-03-29 8:20 ` Vignesh Raghavendra
2019-03-29 8:53 ` Boris Brezillon
2019-03-29 11:01 ` Vignesh Raghavendra
2019-03-29 11:01 ` Vignesh Raghavendra
2019-03-29 11:08 ` Naga Sureshkumar Relli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553771784-3364-1-git-send-email-naga.sureshkumar.relli@xilinx.com \
--to=naga.sureshkumar.relli@xilinx.com \
--cc=bbrezillon@kernel.org \
--cc=broonie@kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=nagasuresh12@gmail.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).