* Re: [PATCH] spi: stm32: return the get_irq error
2019-04-24 12:38 [PATCH] spi: stm32: return the get_irq error Fabien Dessenne
@ 2019-04-24 14:52 ` Amelie DELAUNAY
2019-04-25 19:24 ` Applied "spi: stm32: return the get_irq error" to the spi tree Mark Brown
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Amelie DELAUNAY @ 2019-04-24 14:52 UTC (permalink / raw)
To: Fabien DESSENNE, Mark Brown, Maxime Coquelin, Alexandre TORGUE,
linux-spi@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
On 4/24/19 2:38 PM, Fabien Dessenne wrote:
> During probe, return the "get_irq" error value instead of -ENOENT. This
> allows the driver to be defer probed if needed.
>
> Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
Acked-by: Amelie Delaunay <amelie.delaunay@st.com>
> ---
> drivers/spi/spi-stm32.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c
> index 4186ed2..b222ce8 100644
> --- a/drivers/spi/spi-stm32.c
> +++ b/drivers/spi/spi-stm32.c
> @@ -1839,8 +1839,9 @@ static int stm32_spi_probe(struct platform_device *pdev)
>
> spi->irq = platform_get_irq(pdev, 0);
> if (spi->irq <= 0) {
> - dev_err(&pdev->dev, "no irq: %d\n", spi->irq);
> - ret = -ENOENT;
> + ret = spi->irq;
> + if (ret != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "failed to get irq: %d\n", ret);
> goto err_master_put;
> }
> ret = devm_request_threaded_irq(&pdev->dev, spi->irq,
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Applied "spi: stm32: return the get_irq error" to the spi tree
2019-04-24 12:38 [PATCH] spi: stm32: return the get_irq error Fabien Dessenne
2019-04-24 14:52 ` Amelie DELAUNAY
@ 2019-04-25 19:24 ` Mark Brown
2019-04-25 19:26 ` Mark Brown
2019-05-02 2:18 ` Mark Brown
3 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2019-04-25 19:24 UTC (permalink / raw)
To: Fabien Dessenne
Cc: Alexandre Torgue, Amelie Delaunay, linux-arm-kernel, linux-kernel,
linux-spi, linux-stm32, Mark Brown, Maxime Coquelin
The patch
spi: stm32: return the get_irq error
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.1
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From adb366f61af4486cafb5234aa820721543e21780 Mon Sep 17 00:00:00 2001
From: Fabien Dessenne <fabien.dessenne@st.com>
Date: Wed, 24 Apr 2019 14:38:44 +0200
Subject: [PATCH] spi: stm32: return the get_irq error
During probe, return the "get_irq" error value instead of -ENOENT. This
allows the driver to be defer probed if needed.
Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
Acked-by: Amelie Delaunay <amelie.delaunay@st.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-stm32.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c
index 4186ed20d796..b222ce8d083e 100644
--- a/drivers/spi/spi-stm32.c
+++ b/drivers/spi/spi-stm32.c
@@ -1839,8 +1839,9 @@ static int stm32_spi_probe(struct platform_device *pdev)
spi->irq = platform_get_irq(pdev, 0);
if (spi->irq <= 0) {
- dev_err(&pdev->dev, "no irq: %d\n", spi->irq);
- ret = -ENOENT;
+ ret = spi->irq;
+ if (ret != -EPROBE_DEFER)
+ dev_err(&pdev->dev, "failed to get irq: %d\n", ret);
goto err_master_put;
}
ret = devm_request_threaded_irq(&pdev->dev, spi->irq,
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Applied "spi: stm32: return the get_irq error" to the spi tree
2019-04-24 12:38 [PATCH] spi: stm32: return the get_irq error Fabien Dessenne
2019-04-24 14:52 ` Amelie DELAUNAY
2019-04-25 19:24 ` Applied "spi: stm32: return the get_irq error" to the spi tree Mark Brown
@ 2019-04-25 19:26 ` Mark Brown
2019-05-02 2:18 ` Mark Brown
3 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2019-04-25 19:26 UTC (permalink / raw)
To: Fabien Dessenne
Cc: Alexandre Torgue, Amelie Delaunay, linux-arm-kernel, linux-kernel,
linux-spi, linux-stm32, Mark Brown, Maxime Coquelin
The patch
spi: stm32: return the get_irq error
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.1
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From adb366f61af4486cafb5234aa820721543e21780 Mon Sep 17 00:00:00 2001
From: Fabien Dessenne <fabien.dessenne@st.com>
Date: Wed, 24 Apr 2019 14:38:44 +0200
Subject: [PATCH] spi: stm32: return the get_irq error
During probe, return the "get_irq" error value instead of -ENOENT. This
allows the driver to be defer probed if needed.
Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
Acked-by: Amelie Delaunay <amelie.delaunay@st.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-stm32.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c
index 4186ed20d796..b222ce8d083e 100644
--- a/drivers/spi/spi-stm32.c
+++ b/drivers/spi/spi-stm32.c
@@ -1839,8 +1839,9 @@ static int stm32_spi_probe(struct platform_device *pdev)
spi->irq = platform_get_irq(pdev, 0);
if (spi->irq <= 0) {
- dev_err(&pdev->dev, "no irq: %d\n", spi->irq);
- ret = -ENOENT;
+ ret = spi->irq;
+ if (ret != -EPROBE_DEFER)
+ dev_err(&pdev->dev, "failed to get irq: %d\n", ret);
goto err_master_put;
}
ret = devm_request_threaded_irq(&pdev->dev, spi->irq,
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Applied "spi: stm32: return the get_irq error" to the spi tree
2019-04-24 12:38 [PATCH] spi: stm32: return the get_irq error Fabien Dessenne
` (2 preceding siblings ...)
2019-04-25 19:26 ` Mark Brown
@ 2019-05-02 2:18 ` Mark Brown
3 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2019-05-02 2:18 UTC (permalink / raw)
To: Fabien Dessenne
Cc: Amelie Delaunay, Alexandre Torgue, linux-kernel, linux-spi,
Mark Brown, Maxime Coquelin, linux-stm32, linux-arm-kernel
The patch
spi: stm32: return the get_irq error
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.1
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 8d1467a68426c61807c97163459b481ecb714523 Mon Sep 17 00:00:00 2001
From: Fabien Dessenne <fabien.dessenne@st.com>
Date: Wed, 24 Apr 2019 14:38:44 +0200
Subject: [PATCH] spi: stm32: return the get_irq error
During probe, return the "get_irq" error value instead of -ENOENT. This
allows the driver to be defer probed if needed.
Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
Acked-by: Amelie Delaunay <amelie.delaunay@st.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-stm32.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c
index 4186ed20d796..b222ce8d083e 100644
--- a/drivers/spi/spi-stm32.c
+++ b/drivers/spi/spi-stm32.c
@@ -1839,8 +1839,9 @@ static int stm32_spi_probe(struct platform_device *pdev)
spi->irq = platform_get_irq(pdev, 0);
if (spi->irq <= 0) {
- dev_err(&pdev->dev, "no irq: %d\n", spi->irq);
- ret = -ENOENT;
+ ret = spi->irq;
+ if (ret != -EPROBE_DEFER)
+ dev_err(&pdev->dev, "failed to get irq: %d\n", ret);
goto err_master_put;
}
ret = devm_request_threaded_irq(&pdev->dev, spi->irq,
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread