* Re: [PATCH] spi: stm32-qspi: manage the get_irq error case
2019-04-24 15:19 [PATCH] spi: stm32-qspi: manage the get_irq error case Fabien Dessenne
@ 2019-04-24 15:35 ` Ludovic BARRE
2019-04-25 19:24 ` Applied "spi: stm32-qspi: manage the get_irq error case" to the spi tree Mark Brown
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Ludovic BARRE @ 2019-04-24 15:35 UTC (permalink / raw)
To: Fabien Dessenne, Mark Brown, Maxime Coquelin, Alexandre Torgue,
Christophe KERELLO, linux-spi, linux-stm32, linux-arm-kernel,
linux-kernel
On 4/24/19 5:19 PM, Fabien Dessenne wrote:
> During probe, check the "get_irq" error value.
>
> Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
Acked-by: Ludovic Barre <ludovic.barre@st.com>
> ---
> drivers/spi/spi-stm32-qspi.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c
> index 11a89aa..42f8e3c 100644
> --- a/drivers/spi/spi-stm32-qspi.c
> +++ b/drivers/spi/spi-stm32-qspi.c
> @@ -574,6 +574,12 @@ static int stm32_qspi_probe(struct platform_device *pdev)
> }
>
> irq = platform_get_irq(pdev, 0);
> + if (irq < 0) {
> + if (irq != -EPROBE_DEFER)
> + dev_err(dev, "IRQ error missing or invalid\n");
> + return irq;
> + }
> +
> ret = devm_request_irq(dev, irq, stm32_qspi_irq, 0,
> dev_name(dev), qspi);
> if (ret) {
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Applied "spi: stm32-qspi: manage the get_irq error case" to the spi tree
2019-04-24 15:19 [PATCH] spi: stm32-qspi: manage the get_irq error case Fabien Dessenne
2019-04-24 15:35 ` Ludovic BARRE
@ 2019-04-25 19:24 ` Mark Brown
2019-04-25 19:26 ` Mark Brown
2019-05-02 2:19 ` Mark Brown
3 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2019-04-25 19:24 UTC (permalink / raw)
To: Fabien Dessenne
Cc: Christophe KERELLO, Alexandre Torgue, linux-kernel, linux-spi,
Mark Brown, Ludovic Barre, Maxime Coquelin, linux-stm32,
linux-arm-kernel
The patch
spi: stm32-qspi: manage the get_irq error case
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.2
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 9852254537c499110f6eb32f00a63d8049d04a69 Mon Sep 17 00:00:00 2001
From: Fabien Dessenne <fabien.dessenne@st.com>
Date: Wed, 24 Apr 2019 17:19:00 +0200
Subject: [PATCH] spi: stm32-qspi: manage the get_irq error case
During probe, check the "get_irq" error value.
Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
Acked-by: Ludovic Barre <ludovic.barre@st.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-stm32-qspi.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c
index 11a89aa15d56..42f8e3c6aa1f 100644
--- a/drivers/spi/spi-stm32-qspi.c
+++ b/drivers/spi/spi-stm32-qspi.c
@@ -574,6 +574,12 @@ static int stm32_qspi_probe(struct platform_device *pdev)
}
irq = platform_get_irq(pdev, 0);
+ if (irq < 0) {
+ if (irq != -EPROBE_DEFER)
+ dev_err(dev, "IRQ error missing or invalid\n");
+ return irq;
+ }
+
ret = devm_request_irq(dev, irq, stm32_qspi_irq, 0,
dev_name(dev), qspi);
if (ret) {
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Applied "spi: stm32-qspi: manage the get_irq error case" to the spi tree
2019-04-24 15:19 [PATCH] spi: stm32-qspi: manage the get_irq error case Fabien Dessenne
2019-04-24 15:35 ` Ludovic BARRE
2019-04-25 19:24 ` Applied "spi: stm32-qspi: manage the get_irq error case" to the spi tree Mark Brown
@ 2019-04-25 19:26 ` Mark Brown
2019-05-02 2:19 ` Mark Brown
3 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2019-04-25 19:26 UTC (permalink / raw)
To: Fabien Dessenne
Cc: Christophe KERELLO, Alexandre Torgue, linux-kernel, linux-spi,
Mark Brown, Ludovic Barre, Maxime Coquelin, linux-stm32,
linux-arm-kernel
The patch
spi: stm32-qspi: manage the get_irq error case
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.2
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 9852254537c499110f6eb32f00a63d8049d04a69 Mon Sep 17 00:00:00 2001
From: Fabien Dessenne <fabien.dessenne@st.com>
Date: Wed, 24 Apr 2019 17:19:00 +0200
Subject: [PATCH] spi: stm32-qspi: manage the get_irq error case
During probe, check the "get_irq" error value.
Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
Acked-by: Ludovic Barre <ludovic.barre@st.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-stm32-qspi.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c
index 11a89aa15d56..42f8e3c6aa1f 100644
--- a/drivers/spi/spi-stm32-qspi.c
+++ b/drivers/spi/spi-stm32-qspi.c
@@ -574,6 +574,12 @@ static int stm32_qspi_probe(struct platform_device *pdev)
}
irq = platform_get_irq(pdev, 0);
+ if (irq < 0) {
+ if (irq != -EPROBE_DEFER)
+ dev_err(dev, "IRQ error missing or invalid\n");
+ return irq;
+ }
+
ret = devm_request_irq(dev, irq, stm32_qspi_irq, 0,
dev_name(dev), qspi);
if (ret) {
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Applied "spi: stm32-qspi: manage the get_irq error case" to the spi tree
2019-04-24 15:19 [PATCH] spi: stm32-qspi: manage the get_irq error case Fabien Dessenne
` (2 preceding siblings ...)
2019-04-25 19:26 ` Mark Brown
@ 2019-05-02 2:19 ` Mark Brown
3 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2019-05-02 2:19 UTC (permalink / raw)
To: Fabien Dessenne
Cc: Christophe KERELLO, Alexandre Torgue, linux-kernel, linux-spi,
Mark Brown, Ludovic Barre, Maxime Coquelin, linux-stm32,
linux-arm-kernel
The patch
spi: stm32-qspi: manage the get_irq error case
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.2
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 4b562de4e227dbc2267c367b0a1ec83051c364f6 Mon Sep 17 00:00:00 2001
From: Fabien Dessenne <fabien.dessenne@st.com>
Date: Wed, 24 Apr 2019 17:19:00 +0200
Subject: [PATCH] spi: stm32-qspi: manage the get_irq error case
During probe, check the "get_irq" error value.
Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
Acked-by: Ludovic Barre <ludovic.barre@st.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-stm32-qspi.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c
index 11a89aa15d56..42f8e3c6aa1f 100644
--- a/drivers/spi/spi-stm32-qspi.c
+++ b/drivers/spi/spi-stm32-qspi.c
@@ -574,6 +574,12 @@ static int stm32_qspi_probe(struct platform_device *pdev)
}
irq = platform_get_irq(pdev, 0);
+ if (irq < 0) {
+ if (irq != -EPROBE_DEFER)
+ dev_err(dev, "IRQ error missing or invalid\n");
+ return irq;
+ }
+
ret = devm_request_irq(dev, irq, stm32_qspi_irq, 0,
dev_name(dev), qspi);
if (ret) {
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread