From: Robin Gong <yibin.gong@nxp.com>
To: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"plyatov@gmail.com" <plyatov@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [EXT] Re: [PATCH v2 00/15] add ecspi ERR009165 for i.mx6/7 soc family
Date: Fri, 26 Apr 2019 08:47:03 +0000 [thread overview]
Message-ID: <1556268048.9298.11.camel@nxp.com> (raw)
In-Reply-To: <1556266779.2584.15.camel@pengutronix.de>
On 2019-04-26 at 08:19 +0000, Lucas Stach wrote:
> Caution: EXT Email
>
> Hi Robin,
>
> Am Freitag, den 26.04.2019, 08:05 +0000 schrieb Robin Gong:
> >
> > There is ecspi ERR009165 on i.mx6/7 soc family, which cause FIFO
> > transfer to be send twice in DMA mode. Please get more information
> > from:
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fw
> > ww.nxp.com%2Fdocs%2Fen%2Ferrata%2FIMX6DQCE.pdf&data=02%7C01%7Cy
> > ibin.gong%40nxp.com%7C0078694b231443d1cb7d08d6ca1feecf%7C686ea1d3bc
> > 2b4c6fa92cd99c5c301635%7C0%7C1%7C636918635828489049&sdata=IcPzg
> > uHTS81rdHGMzU2wQdDYJn9bE1UDCsc0BUO5In8%3D&reserved=0. The
> > workaround is adding
> > new sdma ram script which works in XCH mode as PIO inside sdma
> > instead
> > of SMC mode, meanwhile, 'TX_THRESHOLD' should be 0.
> I would like to have a more in-depth explanation about how this new
> RAM
> script differs from the existing ROM script and the changes to the
> state transitions.
The new ecspi ram script just follow errata to enable ecspi XCH bit
after every time txfifo filled just as PIO, please check spi_imx_push()
in spi-imx.c.
>
> >
> > The issue should be exist on all legacy i.mx6/7 soc family before
> > i.mx6ul,
> > NXP fix this design issue from i.mx6ul, so newer chips such as
> > i.mx6ull/
> > i.mx8mq/i.mx8mm, don't need this workaroud anymore. This patch set
> > add new 'fsl,imx6ul-ecspi' for ecspi driver and 'ecspi_fixed' in
> > sdma
> > driver to choose if need errata or not.
> > The first two reverted patches should be the same issue, though,
> > it
> > seems 'fixed' by changing to other shp script. Hope Sean or Sascha
> > could
> > have the chance to test this patch set if could fix their issues.
> > Besides, enable sdma support for i.mx8mm/8mq and fix ecspi1 not
> > work
> > on i.mx8mm because the event id is zero.
> >
> > PS:
> > Please get sdma firmware from below linux-firmware and copy it to
> > your
> > local rootfs /lib/firmware/imx/sdma.
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg
> > it.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ffirmware%2Flinux
> > -firmware.git%2Ftree%2Fimx%2Fsdma&data=02%7C01%7Cyibin.gong%40n
> > xp.com%7C0078694b231443d1cb7d08d6ca1feecf%7C686ea1d3bc2b4c6fa92cd99
> > c5c301635%7C0%7C1%7C636918635828489049&sdata=SMoonJ9HQpUj3TzPmi
> > 7CcCSAwaR44%2BGPi%2BSBj%2FXceqo%3D&reserved=0
> This is not an option as long as the SDMA RAM firmware breaks the
> mainline serial DMA support. Please provide a fixed SDMA RAM firmware
> that doesn't replace the ROM serial script, as that one is totally
> fine.
Yes, I have another patch to fix such uart function broken with SDMA
RAM firmware, including new sdma firmware updated and kernel patch.
Should I add that patch into this patch set?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-26 8:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 8:05 [PATCH v2 00/15] add ecspi ERR009165 for i.mx6/7 soc family Robin Gong
2019-04-26 8:05 ` [PATCH v2 01/15] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" Robin Gong
2019-04-26 8:05 ` [PATCH v2 02/15] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores" Robin Gong
2019-04-26 8:05 ` [PATCH v2 03/15] Revert "dmaengine: imx-sdma: refine to load context only once" Robin Gong
2019-04-26 8:05 ` [PATCH v2 04/15] dmaengine: imx-sdma: remove dupilicated sdma_load_context Robin Gong
2019-04-26 8:05 ` [PATCH v2 05/15] dmaengine: imx-sdma: add mcu_2_ecspi script Robin Gong
2019-04-26 8:05 ` [PATCH v2 06/15] spi: imx: fix ERR009165 Robin Gong
2019-04-26 9:07 ` Lucas Stach
2019-04-26 9:22 ` [EXT] " Robin Gong
2019-04-26 9:37 ` Lucas Stach
2019-04-26 9:53 ` Robin Gong
2019-04-26 8:05 ` [PATCH v2 07/15] spi: imx: remove ERR009165 workaround on i.mx6ul Robin Gong
2019-04-26 9:09 ` Lucas Stach
2019-04-26 9:32 ` [EXT] " Robin Gong
2019-04-26 8:05 ` [PATCH v2 08/15] dt-bindings: spi: imx: add i.mx6ul to state errata fixed Robin Gong
2019-05-01 20:07 ` Rob Herring
2019-05-05 8:55 ` [EXT] " Robin Gong
2019-05-02 6:59 ` Uwe Kleine-König
2019-05-05 8:47 ` [EXT] " Robin Gong
2019-04-26 8:05 ` [PATCH v2 09/15] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul Robin Gong
2019-04-26 8:06 ` [PATCH v2 10/15] dt-bindings: dma: imx-sdma: add i.mx6ul/6sx compatible name Robin Gong
2019-05-01 20:07 ` Rob Herring
2019-04-26 8:06 ` [PATCH v2 11/15] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm Robin Gong
2019-04-26 8:06 ` [PATCH v2 12/15] ARM64: dts: freescale: imx8mm/8mq: update new compatible name for ecspi and sdma Robin Gong
2019-04-26 8:06 ` [PATCH v2 13/15] ARM: dts: imx6ul: add dma support on ecspi Robin Gong
2019-04-26 8:06 ` [PATCH v2 14/15] ARM: dts: imx6sll: correct ecspi/sdma compatible Robin Gong
2019-04-26 8:06 ` [PATCH v2 15/15] arm64: defconfig: Enable SDMA on i.mx8mq/8mm Robin Gong
2019-04-26 8:19 ` [PATCH v2 00/15] add ecspi ERR009165 for i.mx6/7 soc family Lucas Stach
2019-04-26 8:47 ` Robin Gong [this message]
2019-04-26 9:06 ` [EXT] " Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556268048.9298.11.camel@nxp.com \
--to=yibin.gong@nxp.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=plyatov@gmail.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).