From: Keiji Hayashibara <hayashibara.keiji@socionext.com>
To: broonie@kernel.org, yamada.masahiro@socionext.com,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: masami.hiramatsu@linaro.org, jaswinder.singh@linaro.org,
linux-kernel@vger.kernel.org, hayashibara.keiji@socionext.com
Subject: [PATCH 1/3] spi: uniphier: fix wrong register overwrite
Date: Tue, 3 Sep 2019 14:30:59 +0900 [thread overview]
Message-ID: <1567488661-11428-2-git-send-email-hayashibara.keiji@socionext.com> (raw)
In-Reply-To: <1567488661-11428-1-git-send-email-hayashibara.keiji@socionext.com>
When it changes the spi mode, the register is overwritten incorrectly.
This commit fixes this register overwrite.
Signed-off-by: Keiji Hayashibara <hayashibara.keiji@socionext.com>
---
drivers/spi/spi-uniphier.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-uniphier.c b/drivers/spi/spi-uniphier.c
index c1e6f32..e6ebbb1 100644
--- a/drivers/spi/spi-uniphier.c
+++ b/drivers/spi/spi-uniphier.c
@@ -214,6 +214,7 @@ static void uniphier_spi_setup_transfer(struct spi_device *spi,
if (!priv->is_save_param || priv->mode != spi->mode) {
uniphier_spi_set_mode(spi);
priv->mode = spi->mode;
+ priv->is_save_param = false;
}
if (!priv->is_save_param || priv->bits_per_word != t->bits_per_word) {
--
2.7.4
next prev parent reply other threads:[~2019-09-03 5:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 5:30 [PATCH 0/3] spi: uniphier: introduce polling mode and fix bug Keiji Hayashibara
2019-09-03 5:30 ` Keiji Hayashibara [this message]
2019-09-03 11:57 ` Applied "spi: uniphier: fix wrong register overwrite" to the spi tree Mark Brown
2019-09-03 5:31 ` [PATCH 2/3] spi: uniphier: remove unnecessary code Keiji Hayashibara
2019-09-03 11:57 ` Applied "spi: uniphier: remove unnecessary code" to the spi tree Mark Brown
2019-09-03 5:31 ` [PATCH 3/3] spi: uniphier: introduce polling mode Keiji Hayashibara
2019-09-03 11:57 ` Applied "spi: uniphier: introduce polling mode" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1567488661-11428-2-git-send-email-hayashibara.keiji@socionext.com \
--to=hayashibara.keiji@socionext.com \
--cc=broonie@kernel.org \
--cc=jaswinder.singh@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=masami.hiramatsu@linaro.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).