From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 910BCC433E0 for ; Tue, 16 Jun 2020 09:42:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 66C7F20767 for ; Tue, 16 Jun 2020 09:42:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592300520; bh=Sk4uiVB4B7/+E1RJwwK7lA3+sa9J1bh2Mauaa7YcTGs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=vA84F5yoUHYO2DsYOTuNUfsVLruuy9wHfWBfIOm+ikw8S2LPn1AuHSG0X9SvN2I8M uvmQbn7GVNPNQGpAh7aKyBth3w+TbAa105WNgqCwKguUZPrx08o6f3FlzPaypReKYU SCeBgZHkJluFg5yePYdYH+JMVFPlmmDtIopJ0aH0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727966AbgFPJl4 (ORCPT ); Tue, 16 Jun 2020 05:41:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:54988 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726052AbgFPJlz (ORCPT ); Tue, 16 Jun 2020 05:41:55 -0400 Received: from PC-kkoz.proceq.com (unknown [213.160.61.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 201D1207BC; Tue, 16 Jun 2020 09:41:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592300514; bh=Sk4uiVB4B7/+E1RJwwK7lA3+sa9J1bh2Mauaa7YcTGs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uuH6hJ7BzxsYm5ac/1w5A0PPdWJGvffe+XiYFt1N1U4jLkUN/SqqpE7p4nhks72/X wWj5/HjGnQVaGiZpRrFHy2qo57RMQWZt6ScWdYBz4e8ccAN2/kz8Rq/r+us9FwB+kE rK3uK/BdzjNysHtJCXZd2KoUiqOG9d6d2xld1B4w= From: Krzysztof Kozlowski To: Mark Brown , Vladimir Oltean , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Marc Kleine-Budde , Wolfram Sang , Pengutronix Kernel Team , Krzysztof Kozlowski , stable@vger.kernel.org Subject: [PATCH v3 2/2] spi: spi-fsl-dspi: Initialize completion before possible interrupt Date: Tue, 16 Jun 2020 11:41:07 +0200 Message-Id: <1592300467-29196-2-git-send-email-krzk@kernel.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1592300467-29196-1-git-send-email-krzk@kernel.org> References: <1592300467-29196-1-git-send-email-krzk@kernel.org> Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org The interrupt handler calls completion and is IRQ requested before the completion is initialized. Logically it should be the other way. Fixes: 4f5ee75ea171 ("spi: spi-fsl-dspi: Replace interruptible wait queue with a simple completion") Cc: Signed-off-by: Krzysztof Kozlowski --- Changes since v2: 1. None Changes since v1: 1. Rework the commit msg. --- drivers/spi/spi-fsl-dspi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c index 7ecc90ec8f2f..51e0bf617b16 100644 --- a/drivers/spi/spi-fsl-dspi.c +++ b/drivers/spi/spi-fsl-dspi.c @@ -1389,6 +1389,8 @@ static int dspi_probe(struct platform_device *pdev) goto poll_mode; } + init_completion(&dspi->xfer_done); + ret = request_threaded_irq(dspi->irq, dspi_interrupt, NULL, IRQF_SHARED, pdev->name, dspi); if (ret < 0) { @@ -1396,8 +1398,6 @@ static int dspi_probe(struct platform_device *pdev) goto out_clk_put; } - init_completion(&dspi->xfer_done); - poll_mode: if (dspi->devtype_data->trans_mode == DSPI_DMA_MODE) { -- 2.7.4