[PATCH 1/2] spi: imx: Do not print an error when PIO is used

[PATCH 1/2] spi: imx: Do not print an error when PIO is used

[Fabio Estevam]

There are cases that DMA is not used and the driver gracefully
falls back to PIO mode.

Do not treat it like an error message and move it to debug level instead.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 drivers/spi/spi-imx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
index fdc25f549378..a06679ab64f9 100644
--- a/drivers/spi/spi-imx.c
+++ b/drivers/spi/spi-imx.c
@@ -1693,7 +1693,7 @@ static int spi_imx_probe(struct platform_device *pdev)
 			goto out_clk_put;
 
 		if (ret < 0)
-			dev_err(&pdev->dev, "dma setup error %d, use pio\n",
+			dev_dbg(&pdev->dev, "dma setup error %d, use pio\n",
 				ret);
 	}
 
-- 
2.17.1

[PATCH 2/2] spi: imx: Remove unneeded probe message

[Fabio Estevam]

There is no point in printing a plain "probed" message on successful probe.

Just remove it and make the kernel log a bit less noisier.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 drivers/spi/spi-imx.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
index a06679ab64f9..5f5c114ab935 100644
--- a/drivers/spi/spi-imx.c
+++ b/drivers/spi/spi-imx.c
@@ -1708,8 +1708,6 @@ static int spi_imx_probe(struct platform_device *pdev)
 		goto out_clk_put;
 	}
 
-	dev_info(&pdev->dev, "probed\n");
-
 	clk_disable(spi_imx->clk_ipg);
 	clk_disable(spi_imx->clk_per);
 	return ret;
-- 
2.17.1

Re: [PATCH 2/2] spi: imx: Remove unneeded probe message

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

On Tue, Aug 18, 2020 at 07:35:19PM -0300, Fabio Estevam wrote:
> There is no point in printing a plain "probed" message on successful probe.
> 
> Just remove it and make the kernel log a bit less noisier.

This doesn't apply against current code, please check and resend.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 1/2] spi: imx: Do not print an error when PIO is used

[Mark Brown]

On Tue, 18 Aug 2020 19:35:18 -0300, Fabio Estevam wrote:
> There are cases that DMA is not used and the driver gracefully
> falls back to PIO mode.
> 
> Do not treat it like an error message and move it to debug level instead.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/2] spi: imx: Do not print an error when PIO is used
      commit: 0ec0da744bbb11ebb49790e991171a13bf114f9f
[2/2] spi: imx: Remove unneeded probe message
      (no commit info)

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark