From: Marek Vasut <marek.vasut@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Mason Yang <masonccyang@mxic.com.tw>,
tpiepho@impinj.com, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Simon Horman <horms@verge.net.au>,
boris.brezillon@bootlin.com, juliensu@mxic.com.tw,
Geert Uytterhoeven <geert+renesas@glider.be>,
zhengxunli@mxic.com.tw
Subject: Re: [PATCH 1/2] spi: Add Renesas R-Car RPC SPI controller driver
Date: Tue, 20 Nov 2018 14:33:02 +0100 [thread overview]
Message-ID: <1597e984-6b69-1d1e-f033-296d658f8011@gmail.com> (raw)
In-Reply-To: <20181120132624.GD3894@sirena.org.uk>
On 11/20/2018 02:26 PM, Mark Brown wrote:
> On Mon, Nov 19, 2018 at 11:10:04PM +0100, Marek Vasut wrote:
>> On 11/19/2018 04:27 PM, Mark Brown wrote:
>
>>> The SPDX header needs to be C++ style so I push people to make the whole
>>> block C++ otherwise it looks messy.
>
>> OK, I'm not gonna wrestle you on this, but I think it looks horrible ;-)
>
> I don't really like the C++ comment in the first place :(
Then we are in agreement :-)
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2018-11-20 13:33 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 10:01 [PATCH 0/2] spi: Add Renesas R-Car D3 RPC SPI driver Mason Yang
2018-11-19 10:01 ` [PATCH 1/2] spi: Add Renesas R-Car RPC SPI controller driver Mason Yang
2018-11-19 14:12 ` Marek Vasut
2018-11-19 15:27 ` Mark Brown
2018-11-19 22:10 ` Marek Vasut
2018-11-20 13:26 ` Mark Brown
2018-11-20 13:33 ` Marek Vasut [this message]
[not found] ` <OF4FAD10C5.F4F6D29B-ON4825834B.001FAB40-4825834B.00289635@mxic.com.tw>
2018-11-20 13:09 ` Marek Vasut
2018-11-20 13:32 ` Boris Brezillon
2018-11-20 13:35 ` Marek Vasut
[not found] ` <OF5B1A3AE4.2DEECF37-ON4825834E.00031E97-4825834E.00042D72@mxic.com.tw>
2018-11-23 13:34 ` Marek Vasut
2018-11-20 2:04 ` kbuild test robot
2018-11-20 5:49 ` kbuild test robot
2018-11-20 8:01 ` Geert Uytterhoeven
2018-11-20 8:10 ` Boris Brezillon
2018-11-19 10:01 ` [PATCH 2/2] dt-binding: spi: Document Renesas R-Car RPC controller bindings Mason Yang
2018-11-19 13:49 ` Marek Vasut
2018-11-19 14:10 ` Boris Brezillon
2018-11-19 14:14 ` Marek Vasut
2018-11-19 14:43 ` Boris Brezillon
2018-11-19 15:12 ` Marek Vasut
2018-11-19 15:21 ` Boris Brezillon
2018-11-19 22:11 ` Marek Vasut
2018-11-19 22:19 ` Boris Brezillon
2018-11-19 22:22 ` Marek Vasut
2018-11-19 22:25 ` Boris Brezillon
2018-11-19 22:29 ` Marek Vasut
2018-11-19 22:31 ` Boris Brezillon
[not found] ` <OFDD04CD59.10199EDD-ON4825834B.001E1390-4825834B.001F65DD@mxic.com.tw>
2018-11-20 12:57 ` Marek Vasut
[not found] ` <OF26D8352D.B4B02BBE-ON4825834C.00043726-4825834C.0004E2F7@mxic.com.tw>
2018-11-21 1:51 ` Marek Vasut
2018-11-20 8:07 ` Geert Uytterhoeven
2018-11-20 13:56 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1597e984-6b69-1d1e-f033-296d658f8011@gmail.com \
--to=marek.vasut@gmail.com \
--cc=boris.brezillon@bootlin.com \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=juliensu@mxic.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=masonccyang@mxic.com.tw \
--cc=tpiepho@impinj.com \
--cc=zhengxunli@mxic.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).