linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Chuanhong Guo <gch981213@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	linux-spi@vger.kernel.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Richard Weinberger <richard@nod.at>,
	Pratyush Yadav <p.yadav@ti.com>,
	linux-arm-kernel@lists.infradead.org,
	Cai Huoqing <cai.huoqing@linux.dev>,
	Roger Quadros <rogerq@kernel.org>, Yu Kuai <yukuai3@huawei.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	linux-mediatek@lists.infradead.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	devicetree@vger.kernel.org, Mark Brown <broonie@kernel.org>,
	linux-kernel@vger.kernel.org,
	Paul Cercueil <paul@crapouillou.net>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Colin Ian King <colin.king@intel.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH v3 4/5] dt-bindings: spi: add binding doc for spi-mtk-snfi
Date: Mon, 04 Apr 2022 11:08:58 -0500	[thread overview]
Message-ID: <1649088538.050456.1436949.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220404131818.1817794-5-gch981213@gmail.com>

On Mon, 04 Apr 2022 21:18:17 +0800, Chuanhong Guo wrote:
> Add device-tree binding documentation for Mediatek SPI-NAND Flash
> Interface.
> 
> Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
> ---
> Changes since v1:
>   1. add a blank line between properties in dt binding doc
>   2. rename ecc-engine to nand-ecc-engine for the generic properties
> 
> Change since v2: none
> 
>  .../bindings/spi/mediatek,spi-mtk-snfi.yaml   | 88 +++++++++++++++++++
>  1 file changed, 88 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.example.dt.yaml: spi@1100d000: 'ecc-engine' is a required property
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml
Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.example.dt.yaml:0:0: /example-0/soc/spi@1100d000/flash@0: failed to match any schema with compatible: ['spi-nand']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


  parent reply	other threads:[~2022-04-04 21:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-04 13:18 [PATCH v3 0/5] spi: add support for Mediatek SPI-NAND controller Chuanhong Guo
2022-04-04 13:18 ` [PATCH v3 1/5] mtd: nand: make mtk_ecc.c a separated module Chuanhong Guo
2022-04-04 13:18 ` [PATCH v3 2/5] spi: add driver for MTK SPI NAND Flash Interface Chuanhong Guo
2022-04-04 13:18 ` [PATCH v3 3/5] mtd: nand: mtk-ecc: also parse nand-ecc-engine if available Chuanhong Guo
2022-04-04 13:18 ` [PATCH v3 4/5] dt-bindings: spi: add binding doc for spi-mtk-snfi Chuanhong Guo
2022-04-04 13:52   ` Krzysztof Kozlowski
2022-04-04 14:04     ` Mark Brown
2022-04-04 14:15     ` Chuanhong Guo
2022-04-04 16:08   ` Rob Herring [this message]
2022-04-05  2:55     ` Chuanhong Guo
2022-04-05  7:20       ` Miquel Raynal
2022-04-05 14:39         ` Chuanhong Guo
2022-04-05 15:52         ` Rob Herring
2022-04-05 16:08           ` Chuanhong Guo
2022-04-04 13:18 ` [PATCH v3 5/5] arm64: dts: mediatek: add mtk-snfi for mt7622 Chuanhong Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1649088538.050456.1436949.nullmailer@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=broonie@kernel.org \
    --cc=cai.huoqing@linux.dev \
    --cc=colin.king@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=gch981213@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=p.yadav@ti.com \
    --cc=paul@crapouillou.net \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=tsbogend@alpha.franken.de \
    --cc=vigneshr@ti.com \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).