From: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
To: agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, broonie@kernel.org,
linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: quic_msavaliy@quicinc.com, dianders@chromium.org,
mka@chromium.org, swboyd@chromium.org, quic_vtanuku@quicinc.com,
dan.carpenter@linaro.org,
Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
Subject: [PATCH 1/4] spi: spi-qcom-qspi: Ignore disabled interrupts' status in isr
Date: Tue, 25 Jul 2023 17:18:06 +0530 [thread overview]
Message-ID: <1690285689-30233-2-git-send-email-quic_vnivarth@quicinc.com> (raw)
In-Reply-To: <1690285689-30233-1-git-send-email-quic_vnivarth@quicinc.com>
During FIFO/DMA modes dynamic switching, only corresponding interrupts are
enabled. However its possible that FIFO related interrupt status registers
get set during DMA mode. For example WR_FIFO_EMPTY bit is set during DMA
TX.
Ignore such status bits so that they don't trip unwanted operations.
Suggested-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
---
drivers/spi/spi-qcom-qspi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/spi/spi-qcom-qspi.c b/drivers/spi/spi-qcom-qspi.c
index a0ad980..b995542 100644
--- a/drivers/spi/spi-qcom-qspi.c
+++ b/drivers/spi/spi-qcom-qspi.c
@@ -603,6 +603,9 @@ static irqreturn_t qcom_qspi_irq(int irq, void *dev_id)
int_status = readl(ctrl->base + MSTR_INT_STATUS);
writel(int_status, ctrl->base + MSTR_INT_STATUS);
+ /* Ignore disabled interrupts */
+ int_status &= readl(ctrl->base + MSTR_INT_EN);
+
/* PIO mode handling */
if (ctrl->xfer.dir == QSPI_WRITE) {
if (int_status & WR_FIFO_EMPTY)
--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by the Linux Foundation.
next prev parent reply other threads:[~2023-07-25 11:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 11:48 [PATCH 0/4] spi: spi-qcom-qspi: Follow-up patches to DMA mode support Vijaya Krishna Nivarthi
2023-07-25 11:48 ` Vijaya Krishna Nivarthi [this message]
2023-07-25 17:57 ` [PATCH 1/4] spi: spi-qcom-qspi: Ignore disabled interrupts' status in isr Doug Anderson
2023-07-25 11:48 ` [PATCH 2/4] spi: spi-qcom-qspi: Use GFP_ATOMIC flag while allocating for descriptor Vijaya Krishna Nivarthi
2023-07-25 17:58 ` Doug Anderson
2023-07-25 11:48 ` [PATCH 3/4] spi: spi-qcom-qspi: Call dma_wmb() after setting up descriptors Vijaya Krishna Nivarthi
2023-07-25 17:58 ` Doug Anderson
2023-07-25 11:48 ` [PATCH 4/4] spi: spi-qcom-qspi: Add DMA_CHAIN_DONE to ALL_IRQS Vijaya Krishna Nivarthi
2023-07-25 17:58 ` Doug Anderson
2023-07-25 20:36 ` [PATCH 0/4] spi: spi-qcom-qspi: Follow-up patches to DMA mode support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1690285689-30233-2-git-send-email-quic_vnivarth@quicinc.com \
--to=quic_vnivarth@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=dianders@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mka@chromium.org \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_vtanuku@quicinc.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).