Re: [PATCH] spi: tegra210-quad: downgrade the log when fall back to PIO

Jon Hunter
2025-12-10T04:24:31Z

On 27/11/2025 13:02, Guixin Liu wrote:
> When the machine boots using ACPI, Tegra cannot use DMA and falls back
> to PIO. In this case, logging these messages as "Error" may confuse
> users into thinking it is an actual error; therefore, these two log
> messages should be downgraded to "Info" level.

Which Tegra device are you using?

> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
> ---
> drivers/spi/spi-tegra210-quad.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-tegra210-quad.c b/drivers/spi/spi-tegra210-quad.c
> index 3be7499db21e..2189904b931d 100644
> --- a/drivers/spi/spi-tegra210-quad.c
> +++ b/drivers/spi/spi-tegra210-quad.c
> @@ -823,8 +823,8 @@ static int tegra_qspi_init_dma(struct tegra_qspi *tqspi)
> tegra_qspi_deinit_dma(tqspi);
>
> if (err != -EPROBE_DEFER) {
> - dev_err(tqspi->dev, "cannot use DMA: %d\n", err);
> - dev_err(tqspi->dev, "falling back to PIO\n");
> + dev_info(tqspi->dev, "cannot use DMA: %d\n", err);
> + dev_info(tqspi->dev, "falling back to PIO\n");
> return 0;
> }

This change would potentially hide an actual case where the DMA
initialisation fails when booting with device-tree.

Jon

--
nvpublic