From: "Rob Herring (Arm)" <robh@kernel.org>
To: Zixian Zeng <sycamoremoon376@gmail.com>
Cc: Richard Weinberger <richard@nod.at>,
Chen Wang <unicorn_wang@outlook.com>,
Conor Dooley <conor+dt@kernel.org>,
Mark Brown <broonie@kernel.org>,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Albert Ou <aou@eecs.berkeley.edu>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Inochi Amaoto <inochiama@gmail.com>,
linux-kernel@vger.kernel.org, Alexandre Ghiti <alex@ghiti.fr>,
dlan@gentoo.org, Miquel Raynal <miquel.raynal@bootlin.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
sophgo@lists.linux.dev, linux-mtd@lists.infradead.org,
linux-spi@vger.kernel.org, Longbin Li <looong.bin@gmail.com>,
ziyao@disroot.org, Paul Walmsley <paul.walmsley@sifive.com>,
Michael Walle <mwalle@kernel.org>,
Pratyush Yadav <pratyush@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>
Subject: Re: [PATCH 1/3] dt-bindings: spi: Add bindings for SOPHGO SG2042
Date: Fri, 23 May 2025 07:22:34 -0500 [thread overview]
Message-ID: <174800295404.1369155.8184258827735093868.robh@kernel.org> (raw)
In-Reply-To: <20250523-sfg-spifmc-v1-1-4cf16cf3fd2a@gmail.com>
On Fri, 23 May 2025 18:54:49 +0800, Zixian Zeng wrote:
> Add bindings for the SOPHGO SG2042 SPI-NOR flash controller,
> which is compatible with SOPHGO SG2044.
>
> Signed-off-by: Zixian Zeng <sycamoremoon376@gmail.com>
> ---
> Documentation/devicetree/bindings/spi/spi-sg2044-nor.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/spi/spi-sg2044-nor.yaml:20:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/spi/spi-sg2044-nor.example.dtb: spi@1000000 (sophgo,sg2044-spifmc-nor): compatible:0: 'sophgo,sg2044-spifmc-nor' is not one of ['sophgo,sg2042-spifmc-nor']
from schema $id: http://devicetree.org/schemas/spi/spi-sg2044-nor.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/spi/spi-sg2044-nor.example.dtb: spi@1000000 (sophgo,sg2044-spifmc-nor): compatible: ['sophgo,sg2044-spifmc-nor'] is too short
from schema $id: http://devicetree.org/schemas/spi/spi-sg2044-nor.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/spi/spi-sg2044-nor.example.dtb: spi@1000000 (sophgo,sg2044-spifmc-nor): Unevaluated properties are not allowed ('compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/spi/spi-sg2044-nor.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250523-sfg-spifmc-v1-1-4cf16cf3fd2a@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-05-23 12:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 10:54 [PATCH 0/3] spi: sophgo: Add SPI NOR controller for SG2042 Zixian Zeng
2025-05-23 10:54 ` [PATCH 1/3] dt-bindings: spi: Add bindings for SOPHGO SG2042 Zixian Zeng
2025-05-23 11:33 ` Krzysztof Kozlowski
2025-05-23 13:31 ` Zixian Zeng
2025-05-23 12:22 ` Rob Herring (Arm) [this message]
2025-05-23 10:54 ` [PATCH 2/3] mtd: spi-nor: Add GD25LB512ME GigaDevice flash_info Zixian Zeng
2025-05-23 11:16 ` Michael Walle
2025-05-23 16:18 ` Zixian Zeng
2025-05-27 16:30 ` Pratyush Yadav
2025-05-23 10:54 ` [PATCH 3/3] riscv: dts: sophgo: Add SPI NOR node for SG2042 Zixian Zeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174800295404.1369155.8184258827735093868.robh@kernel.org \
--to=robh@kernel.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=inochiama@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=looong.bin@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=mwalle@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=sophgo@lists.linux.dev \
--cc=sycamoremoon376@gmail.com \
--cc=tudor.ambarus@linaro.org \
--cc=unicorn_wang@outlook.com \
--cc=vigneshr@ti.com \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox