public inbox for linux-spi@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] spi: tle62x0: Add newline to sysfs attribute output
@ 2025-10-30 12:47 Zhongqiu Han
  2025-10-30 14:54 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Zhongqiu Han @ 2025-10-30 12:47 UTC (permalink / raw)
  To: broonie; +Cc: linux-spi, linux-kernel, zhongqiu.han

Append a newline to the sysfs_emit() output in tle62x0_gpio_show. This
aligns with common kernel conventions and improves readability for
userspace tools that expect newline-terminated values.

Signed-off-by: Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>
---
 drivers/spi/spi-tle62x0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-tle62x0.c b/drivers/spi/spi-tle62x0.c
index a565352f6381..663c0136d119 100644
--- a/drivers/spi/spi-tle62x0.c
+++ b/drivers/spi/spi-tle62x0.c
@@ -141,7 +141,7 @@ static ssize_t tle62x0_gpio_show(struct device *dev,
 	value = (st->gpio_state >> gpio_num) & 1;
 	mutex_unlock(&st->lock);
 
-	return sysfs_emit(buf, "%d", value);
+	return sysfs_emit(buf, "%d\n", value);
 }
 
 static ssize_t tle62x0_gpio_store(struct device *dev,
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] spi: tle62x0: Add newline to sysfs attribute output
  2025-10-30 12:47 [PATCH] spi: tle62x0: Add newline to sysfs attribute output Zhongqiu Han
@ 2025-10-30 14:54 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2025-10-30 14:54 UTC (permalink / raw)
  To: Zhongqiu Han; +Cc: linux-spi, linux-kernel

On Thu, 30 Oct 2025 20:47:55 +0800, Zhongqiu Han wrote:
> Append a newline to the sysfs_emit() output in tle62x0_gpio_show. This
> aligns with common kernel conventions and improves readability for
> userspace tools that expect newline-terminated values.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: tle62x0: Add newline to sysfs attribute output
      commit: ecd0de438c1f0ee86cf8f6d5047965a2a181444b

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-10-30 14:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-30 12:47 [PATCH] spi: tle62x0: Add newline to sysfs attribute output Zhongqiu Han
2025-10-30 14:54 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox