From: "Rob Herring (Arm)" <robh@kernel.org>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: devicetree@vger.kernel.org,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"David Lechner" <dlechner@baylibre.com>,
"Mark Brown" <broonie@kernel.org>, "Nuno Sá" <nuno.sa@analog.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
linux-kernel@vger.kernel.org,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Olivier Moysan" <olivier.moysan@foss.st.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-spi@vger.kernel.org, "Jonathan Cameron" <jic23@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v3 4/5] dt-bindings: iio: adc: ad4080: add AD4880 support
Date: Fri, 13 Feb 2026 10:34:19 -0600 [thread overview]
Message-ID: <177100045980.2534776.8079356391569945808.robh@kernel.org> (raw)
In-Reply-To: <20260213144742.16394-5-antoniu.miclaus@analog.com>
On Fri, 13 Feb 2026 16:47:36 +0200, Antoniu Miclaus wrote:
> Add support for the AD4880, a dual-channel 20-bit 40MSPS SAR ADC
> with integrated fully differential amplifiers (FDA).
>
> The AD4880 has two independent ADC channels, each with its own SPI
> configuration interface. This requires:
> - Two entries in reg property for primary and secondary channel
> chip selects
> - Two io-backends entries for the two data channels
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> Changes in v3:
> - Add items descriptions for io-backends entries
> - Fix reg example format: reg = <0 1> -> reg = <0>, <1>
>
> .../bindings/iio/adc/adi,ad4080.yaml | 54 ++++++++++++++++++-
> 1 file changed, 52 insertions(+), 2 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml: properties:io-backends: {'minItems': 1, 'maxItems': 2, 'items': [{'description': 'Backend for channel A (primary)'}, {'description': 'Backend for channel B (secondary)'}]} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.kernel.org/project/devicetree/patch/20260213144742.16394-5-antoniu.miclaus@analog.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2026-02-13 16:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 14:47 [PATCH v3 0/5] iio: adc: ad4080: add support for AD4880 dual-channel ADC Antoniu Miclaus
2026-02-13 14:47 ` [PATCH v3 1/5] spi: allow ancillary devices to share parent's chip selects Antoniu Miclaus
2026-02-13 16:39 ` Nuno Sá
2026-02-15 18:36 ` Jonathan Cameron
2026-02-13 14:47 ` [PATCH v3 2/5] spi: add devm_spi_new_ancillary_device() Antoniu Miclaus
2026-02-13 16:40 ` Nuno Sá
2026-02-13 14:47 ` [PATCH v3 3/5] iio: backend: add devm_iio_backend_get_by_index() Antoniu Miclaus
2026-02-13 16:33 ` Nuno Sá
2026-02-13 14:47 ` [PATCH v3 4/5] dt-bindings: iio: adc: ad4080: add AD4880 support Antoniu Miclaus
2026-02-13 16:34 ` Rob Herring (Arm) [this message]
2026-02-14 8:54 ` Krzysztof Kozlowski
2026-02-13 14:47 ` [PATCH v3 5/5] iio: adc: ad4080: add support for AD4880 dual-channel ADC Antoniu Miclaus
2026-02-13 16:43 ` Nuno Sá
2026-02-15 18:42 ` Jonathan Cameron
2026-02-15 18:34 ` [PATCH v3 0/5] " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177100045980.2534776.8079356391569945808.robh@kernel.org \
--to=robh@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox