From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B20743A4F50 for ; Tue, 25 Aug 2026 04:01:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787630463; cv=none; b=rt9rMtCYkNsEEFFThRrNRVF3Qe67R2RRgeqNXP03n6jcFnaKl1+3i+lvEIReSmc0XBtItumu5b/hGnTc82IKfEmrkCCSrq5oNgkYtQWWREBHL7YngbC26dE//Ua5Yd1zKJ0KoTU51VeoukWBVw8C6tJ98U0ydQqIIOQsRIRdfrE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787630463; c=relaxed/simple; bh=YWl90OOdVCd9KNVgHHy4ovXFe+CNKeFkWuTjHDRfD6g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Y532P2vI+B4ktU47WKmBqIRzBpoUJiTjwucLmdyn7jc8BHOad66OM+AVMd6MIvuLjCi1Rfk67B5T6sSII5aWegNsD4X5d2gZ9a8J5v53tdEufdsjESnw3APsimUitz8RVmyUYR5PlDJSQ5watnTVUYBEAnnocP3kaqB7seD7LX8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CIKC2iN1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YUzmf28P; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CIKC2iN1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YUzmf28P" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67P2RG3E120846 for ; Tue, 25 Aug 2026 04:01:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= C+XQZtMktBy7ekGjf4/plKpxlv6MDb59qUzxqeoByG0=; b=CIKC2iN1ZReAWWl4 16vuxGWUUJO4xlufvERdBG5vjw/2gSxGqmXPC3TO7qRE01rxoNS3b0E6F0UWkQ2K QckfiY4rR5jXrMqy40XdPryMBVmLBSUaL1UuSGjLWV3KIy/uz/xZtAAgmhlzp45M HK6JULyoHkGuMBOxSZabRJxkrGFdjLMMe7TdnLRgD8zBLP2vm4w7v9ancNLyWVLl TgxoTUwWMI3dGtzARP2pFInlrRH+smkBhuxm1CGTOAzZXx0kht45IKSJhqTpbV9S zVl47i3TaNETzacmw0QpARosk1k2JHFISAAOM+BmBeD6LzEjWK1uqsXsKcydMsBX GhzTgg== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g8t3dt061-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 25 Aug 2026 04:01:00 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-84865f326efso4231170b3a.0 for ; Mon, 24 Aug 2026 21:01:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787630459; x=1788235259; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=C+XQZtMktBy7ekGjf4/plKpxlv6MDb59qUzxqeoByG0=; b=YUzmf28PbofztZn+3f0/ELIvx+6cCQcsbwmPEYaPiz6h5VT2Phr665iE0ArPYqKHDO w//j1xbT+toYiugC6yEmrZnLVaH4nuRFwAZfmsRlCXYS9hvcgKbszOMK9ZJVUVHWRC84 QX2nMEX2AMu3R1JKs9aID9ijNMgFuFvuEn4mdNMfp1i7b70HRdzGSzUdzjkeK5FhPCEL V9ZBWgGESSVU9tUSgGrsUhy6SoSXtGSNdnKENqhOofkuXYRs52fvi4Dv/zx86nyWAKl9 S4AsylhRJD8CNh68wLzhEO+hA7loJskQEe5HcGZfTltlXhYb3k8Hiuwp2nWhj4P0vX2P l7dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787630459; x=1788235259; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=C+XQZtMktBy7ekGjf4/plKpxlv6MDb59qUzxqeoByG0=; b=WFK0dxOC3XI9RVuZCuN8Rxf5uUc/3h17zhzJnC7+1Z0Q8DXCzXTDGL/17dQOdeVf8Q 7TIIlCxeB/AqaLQRa0Qwk2cHue/jVD45eZeloXhW/Sg3l0fM/f8ETspvyQx7ApWxLRjW eMdOTgRcocVD0+pctmBHi83AsZdglqwmbwquAUhcl3fFhpC4OJnxBiktt6P2uzRRnRP+ Kw3UTI+fYg4MgoInHCH8V5/KmayVuiCdCFDW6HOr70B/XWxY/A+WYh/U9p72Tlgqy0uQ blyzBjaEGrNc3k5Wv1CotWZRB5caz4O7lcJskQvU3BGQKWUO1nmCTDcZ39TUUbQt21T+ p5xQ== X-Forwarded-Encrypted: i=1; AHgh+RoBWvrqPaT/7M+tfR4CMiwFQNtNC02j016C9w6QQQj5GBnj/f2J+BNOXZwvCnIO/BQkWD9hyTz/M+8=@vger.kernel.org X-Gm-Message-State: AFuF++ktM4oh0DhW/3+trWX47RXyMVpnxxNs+Zg/1ZA/QaJHjTdCebmN G0gqpfHWwdoatJ7SLXZe7udw/Aouu8zx1xGbMxnm4EaFA9GdJZ7LVHRw/uhdBCMrmLb6m5v0h7F Os4Bi89NncOAE/xXfA97Y8hY4jw40Zd9fr3KfADlpITXHAqtUA27IKJdHmFXnE6M= X-Gm-Gg: AR+sD13oL75GwM8Iu5VbxSzCvw/vjZ0Y5kSiQjkpJYKcFdDgJkEnSNQ7xrYMHJaXf7w Q4X4ou9kOPvoDH2n1Bn2i9fsTnkrVwkK9SVgNrXtOgaRZV9PrH6A674QCOkyoQYVkuZvODL4+4F E/t4aGWLqbb5IwedOwpzMgs1K8D4IvdxPLtiTd+m7xpJt0+rQo7gkR5c8ZzTVD2MBal++Ople6+ Dq4rl/bx4tBjvgyNVTARYV5WisjDbPLTOJgshy4hIex6U80PMzDrwMDq81tSkqy9dRpofm7tjYV Gg2CTMbdA/VX1DXeDKKDgCFnlJIzFG2ameas4+z3HkJF4C+js8f/kngys03nOTpQyL+Ex3n1Esl G9nEy46+waHccL1yh2NM/n5Q+SPBh2QE= X-Received: by 2002:a05:6a00:4c13:b0:851:8bde:7873 with SMTP id d2e1a72fcca58-8520b98be69mr40252200b3a.8.1787630459248; Mon, 24 Aug 2026 21:00:59 -0700 (PDT) X-Received: by 2002:a05:6a00:4c13:b0:851:8bde:7873 with SMTP id d2e1a72fcca58-8520b98be69mr40252038b3a.8.1787630458620; Mon, 24 Aug 2026 21:00:58 -0700 (PDT) Received: from [10.218.14.97] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8520f1638aesm2534359b3a.57.2026.08.24.21.00.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Aug 2026 21:00:58 -0700 (PDT) Message-ID: <17735f83-fd07-4fad-97a3-727cfbeabbcb@oss.qualcomm.com> Date: Tue, 25 Aug 2026 09:30:50 +0530 Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/7] serial: qcom-geni: Use geni_se_set_rate() for source clock configuration To: Konrad Dybcio , Sudeep Holla , Cristian Marussi , Ulf Hansson , Bjorn Andersson , Konrad Dybcio , Greg Kroah-Hartman , Jiri Slaby , Mark Brown , Viken Dadhaniya , Andi Shyti Cc: mukesh.savaliya@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, linux-i2c@vger.kernel.org References: <20260805-derive_clk_perf_tbl_from_perf_domain_opp_table-v1-0-61171ab1cdce@oss.qualcomm.com> <20260805-derive_clk_perf_tbl_from_perf_domain_opp_table-v1-4-61171ab1cdce@oss.qualcomm.com> <4e0d636a-7975-4711-8070-6f71957b754e@oss.qualcomm.com> Content-Language: en-US From: Praveen Talari In-Reply-To: <4e0d636a-7975-4711-8070-6f71957b754e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: gAWHB1PXbq4Bt-ahtYVmQjejRP-FzkRe X-Authority-Analysis: v=2.4 cv=OLAXGyaB c=1 sm=1 tr=0 ts=6a8d137c cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=gztmCChag-4to_nYmxUA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-GUID: gAWHB1PXbq4Bt-ahtYVmQjejRP-FzkRe X-Proofpoint-Spam-Info: AW1haW4tMjYwODI1MDAzMSBTYWx0ZWRfXwE9a/ivSXwHz wbE2amrUlhAJllZl/Cdw0jK8zAUHAEmADYSd+qUeCEa1ZNzNSNPh8M5IfpeTPy6WMv02dTayWC9 NO3ssSPUsgLoxD1+iYXTHW6Y4H9C4iw= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI1MDAzMSBTYWx0ZWRfXzW3B7CqRSN57 eirHcY7fQ7zJ0tFhEL3b2g6BIk2sL5wEmeF66MJ3XTI/MaB3Y0bko4Ex8ZLC3OsW3WdFlej8+1p d1QrJXi6nkLSeUK2ztu7n4Jpg8jvUe9qX5EE4t9mKaspVb8gUoKnCzE/o97XirkhpaAz9U+9N/O YSGKlK0zjJ2Bn3KSmGST8YB2UvMn5diuFOm8DimIWvnhbtUKXWOO7Nj6uw6iD3n0SjsjJHlgjeP T01hH+PCCrq258LWXLdqsKp8NS/giJ5ackMc4VcuIB/ozEmVO7tA8KQ1cvh0IuFExaEh9Qxy5Lq wghTuU6vyq1BZRlJnn/U19q6oYSqahkCZ9WEGPC0PYtBhlWT+nJ2V2ytD6xeHFTCrpdaHoKYrzQ O9IwGKL9hTlawkqhBXvt/s3Gecs/Ytwo60NuFs46xmZ62J3fvFcAswdxTQdNxcvkqhTIBJPSRZa xrHY2IdSC99/58Poo7w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-25_01,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 adultscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 spamscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608250031 HI Konrad, On 24-08-2026 20:35, Konrad Dybcio wrote: > On 8/4/26 9:57 PM, Praveen Talari wrote: >> The driver calls dev_pm_opp_set_rate() directly on uport->dev to apply >> the computed source clock frequency, and dispatches baud rate handling >> through a per-variant dev_data->set_rate() callback that either >> recalculates the clock divider (Linux clock managed path) or selects >> a performance level via geni_se_set_perf_level() (SA8255P firmware >> managed path). > [...] > >> + geni_se_set_rate(&port->se, 0); > This ends up calling dev_pm_opp_set_rate(0) [i see this is an existing > bug in geni_se_resources_deactivate()], which removes the power vote, > but does nothing to the clock (neither set_rate nor disable_unprepare), > which will crash the platform > > Both of these calls (new and existing) should be removed. Clocks will > be disabled by geni_se_clks_off() in geni_se_resources_deactivate(). > > Then, we should do dev_pm_set_opp(se->dev, NULL) *after* they are off > to remove any trailing OPP resources (i.e. icc votes defined in the OPP > table in our case) So, if I understand correctly, the expected sequence is: 1. Disable the clocks. 2. Remove the OPP/performance resources. Thanks, Praveen Talari > > Konrad