From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Conor Dooley <conor+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Jaroslav Kysela <perex@perex.cz>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Takashi Iwai <tiwai@suse.com>,
devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-sound@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH 1/7] spi: renesas,sh-msiof: Living separately from MSIOF I2S Sound
Date: Thu, 10 Apr 2025 07:48:39 +0200 [thread overview]
Message-ID: <17e20b8a-dd96-4d7e-a05f-f7fecc49469e@kernel.org> (raw)
In-Reply-To: <877c3sncs9.wl-kuninori.morimoto.gx@renesas.com>
On 10/04/2025 01:19, Kuninori Morimoto wrote:
>
> Hi
>
>>> Renesas MSIOF (Clock-Synchronized Serial Interface with FIFO) can work as
>>> both SPI and I2S. MSIOF-I2S will use Audio Graph Card/Card2 driver which
>>> uses Of-Graph in DT.
>>>
>>> MSIOF-SPI/I2S are using same DT compatible properties.
>>> MSIOF-I2S uses Of-Graph for Audio-Graph-Card/Card2,
>>> MSIOF-SPI doesn't use Of-Graph.
>>>
>>> Ignore MSIOF-I2S case (= Of-Graph) in MSIOF-SPI Doc.
>>
>> Please use subject prefixes matching the subsystem. You can get them for
>> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
>> your patch is touching.
>
> Yeah, I did :)
>
> git log --oneline --no-merges Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
So run it on the directory. Apparently many contributors decided to
ignore Mark's rule about naming and if people ignore Mark's rule, Mark
was removing dt-bindings prefix, thus you have what you have below:
>
> 1f48cbd6f00f spi: renesas,sh-msiof: Add r8a779h0 support
> a0dcd1ff9629 spi: renesas,sh-msiof: Miscellaneous improvements
> aa69dc65e3b3 spi: renesas,sh-msiof: Add r8a779g0 support
> f4d381038700 spi: renesas,sh-msiof: Fix 'unevaluatedProperties' warnings
> b076fdd02133 spi: renesas,sh-msiof: R-Car V3U is R-Car Gen4
> e1e62f05d5d9 spi: renesas,sh-msiof: Add generic Gen4 and r8a779f0 support
> 5a674d9dc9a0 dt-bindings: Fix array constraints on scalar properties
> 6be69293196c spi: renesas,sh-msiof: Add r8a779a0 support
> 6fdc6e23a7d1 dt-bindings: Add missing 'unevaluatedProperties'
> aef161f4f1b8 spi: renesas,sh-msiof: Add r8a77961 support
> b4f7f5f54705 spi: renesas,sh-msiof: Add r8a774e1 support
> 6383b118efaf spi: renesas,sh-msiof: Add r8a7742 support
Prefixes are explained in the docs I linked to.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-10 5:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 1:04 [PATCH 0/7] ASoC: add Renesas MSIOF sound driver Kuninori Morimoto
2025-03-18 2:06 ` [PATCH 1/7] spi: renesas,sh-msiof: Living separately from MSIOF I2S Sound Kuninori Morimoto
2025-04-09 6:31 ` Krzysztof Kozlowski
2025-04-09 23:19 ` Kuninori Morimoto
2025-04-10 5:48 ` Krzysztof Kozlowski [this message]
2025-04-09 1:05 ` [PATCH 2/7] spi: sh-msiof: ignore driver probing if it was MSIOF Sound Kuninori Morimoto
2025-04-09 7:09 ` Geert Uytterhoeven
2025-04-09 23:31 ` Kuninori Morimoto
2025-04-09 1:05 ` [PATCH 3/7] ASoC: rsnd: allow to use ADG only Kuninori Morimoto
2025-04-09 1:05 ` [PATCH 4/7] ASoC: rsnd: enable to use "adg" clock Kuninori Morimoto
2025-04-09 1:05 ` [PATCH 5/7] ASoC: renesas: add MSIOF sound Documentation Kuninori Morimoto
2025-04-09 6:37 ` Krzysztof Kozlowski
2025-04-09 7:01 ` Geert Uytterhoeven
2025-04-09 7:52 ` Krzysztof Kozlowski
2025-04-09 8:09 ` Geert Uytterhoeven
2025-04-09 12:08 ` Krzysztof Kozlowski
2025-04-09 7:41 ` Krzysztof Kozlowski
2025-04-10 0:49 ` Kuninori Morimoto
2025-04-10 5:46 ` Krzysztof Kozlowski
2025-04-10 7:02 ` Kuninori Morimoto
2025-04-09 1:05 ` [PATCH 6/7] ASoC: renesas: add MSIOF sound support Kuninori Morimoto
2025-04-09 6:38 ` Krzysztof Kozlowski
2025-04-09 23:25 ` Kuninori Morimoto
2025-04-10 5:45 ` Krzysztof Kozlowski
2025-04-10 6:29 ` Kuninori Morimoto
2025-04-10 6:33 ` Krzysztof Kozlowski
2025-04-09 7:28 ` Geert Uytterhoeven
2025-04-09 23:45 ` Kuninori Morimoto
2025-04-10 2:37 ` Kuninori Morimoto
2025-04-10 7:39 ` Geert Uytterhoeven
2025-04-10 23:04 ` Kuninori Morimoto
2025-04-10 7:47 ` Geert Uytterhoeven
2025-04-10 23:08 ` Kuninori Morimoto
2025-04-09 1:05 ` [PATCH 7/7] arm64: dts: renesas: sparrow hawk: Add MSIOF Sound support Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17e20b8a-dd96-4d7e-a05f-f7fecc49469e@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzk+dt@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).