linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 30/50] spi: dt-bindings: atmel,at91rm9200-spi: remove 9x60 compatible from list
@ 2023-07-28 10:28 Varshini Rajendran
  2023-07-28 11:50 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 2+ messages in thread
From: Varshini Rajendran @ 2023-07-28 10:28 UTC (permalink / raw)
  To: broonie, robh+dt, krzysztof.kozlowski+dt, conor+dt, nicolas.ferre,
	alexandre.belloni, claudiu.beznea, tudor.ambarus, linux-spi,
	devicetree, linux-arm-kernel, linux-kernel
  Cc: varshini.rajendran

Remove microchip,sam9x60-spi compatible from the list as the fallback is
really atmel,at91rm9200-spi.

Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
---
 Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml
index 58367587bfbc..32e7c14033c2 100644
--- a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml
+++ b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml
@@ -22,7 +22,6 @@ properties:
           - const: atmel,at91rm9200-spi
       - items:
           - const: microchip,sam9x7-spi
-          - const: microchip,sam9x60-spi
           - const: atmel,at91rm9200-spi
 
   reg:
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v3 30/50] spi: dt-bindings: atmel,at91rm9200-spi: remove 9x60 compatible from list
  2023-07-28 10:28 [PATCH v3 30/50] spi: dt-bindings: atmel,at91rm9200-spi: remove 9x60 compatible from list Varshini Rajendran
@ 2023-07-28 11:50 ` Krzysztof Kozlowski
  0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-28 11:50 UTC (permalink / raw)
  To: Varshini Rajendran, broonie, robh+dt, krzysztof.kozlowski+dt,
	conor+dt, nicolas.ferre, alexandre.belloni, claudiu.beznea,
	tudor.ambarus, linux-spi, devicetree, linux-arm-kernel,
	linux-kernel

On 28/07/2023 12:28, Varshini Rajendran wrote:
> Remove microchip,sam9x60-spi compatible from the list as the fallback is
> really atmel,at91rm9200-spi.

Sorry, this explanation tells me nothing. The fallback is really
microchip,sam9x60-spi... You need to explain in commit msg why sam9x60
is incorrect as fallback.

> 
> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
> ---
>  Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml
> index 58367587bfbc..32e7c14033c2 100644
> --- a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml
> @@ -22,7 +22,6 @@ properties:
>            - const: atmel,at91rm9200-spi
>        - items:
>            - const: microchip,sam9x7-spi
> -          - const: microchip,sam9x60-spi

If that's true, then it should be part of previous enum.

>            - const: atmel,at91rm9200-spi
>  
>    reg:

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-07-28 11:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-28 10:28 [PATCH v3 30/50] spi: dt-bindings: atmel,at91rm9200-spi: remove 9x60 compatible from list Varshini Rajendran
2023-07-28 11:50 ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).