From: Neil Armstrong <neil.armstrong@linaro.org>
To: Wei Yongjun <weiyongjun@huaweicloud.com>,
Mark Brown <broonie@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>
Cc: Wei Yongjun <weiyongjun1@huawei.com>,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] spi: meson-spicc: make symbol 'meson_spicc_pow2_clk_ops' static
Date: Thu, 22 Sep 2022 11:23:44 +0200 [thread overview]
Message-ID: <19f10c64-efec-e2c7-a39d-0f346d6936fa@linaro.org> (raw)
In-Reply-To: <20220922040807.1409540-1-weiyongjun@huaweicloud.com>
On 22/09/2022 06:08, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> The sparse tool complains as follows:
>
> drivers/spi/spi-meson-spicc.c:570:22: warning:
> symbol 'meson_spicc_pow2_clk_ops' was not declared. Should it be static?
>
> This symbol is not used outside of spi-meson-spicc.c, so marks it static.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/spi/spi-meson-spicc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c
> index e4cb52e1fe26..85b4b9b267b1 100644
> --- a/drivers/spi/spi-meson-spicc.c
> +++ b/drivers/spi/spi-meson-spicc.c
> @@ -567,7 +567,7 @@ static int meson_spicc_pow2_set_rate(struct clk_hw *hw, unsigned long rate,
> return clk_divider_ops.set_rate(hw, rate, parent_rate);
> }
>
> -const struct clk_ops meson_spicc_pow2_clk_ops = {
> +static const struct clk_ops meson_spicc_pow2_clk_ops = {
> .recalc_rate = meson_spicc_pow2_recalc_rate,
> .determine_rate = meson_spicc_pow2_determine_rate,
> .set_rate = meson_spicc_pow2_set_rate,
>
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2022-09-22 9:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 4:08 [PATCH -next] spi: meson-spicc: make symbol 'meson_spicc_pow2_clk_ops' static Wei Yongjun
2022-09-22 9:23 ` Neil Armstrong [this message]
2022-09-22 17:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19f10c64-efec-e2c7-a39d-0f346d6936fa@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=broonie@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=weiyongjun1@huawei.com \
--cc=weiyongjun@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox