From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 561B1EB64DA for ; Tue, 4 Jul 2023 09:40:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231441AbjGDJkm (ORCPT ); Tue, 4 Jul 2023 05:40:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231359AbjGDJkc (ORCPT ); Tue, 4 Jul 2023 05:40:32 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E49C1FE7 for ; Tue, 4 Jul 2023 02:38:23 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-992ace062f3so646239766b.2 for ; Tue, 04 Jul 2023 02:38:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688463501; x=1691055501; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ERnzPIPRvWevLboQhEVq6zSzhxrqqEGbLmA9tpsiGI0=; b=irSJlz54V83Ic3w9B7kkZVmPaAKj8rOOaqqHxt4z2EndhT+6OFdL5rl1MkfCEmcUk+ U2b3+TQaYECpAxUhcgDPZVbeP7cp3TFOAOkaJ+YG79KoF6emCpXHgWnalOOjl96k8AGO BChhV9m4pIftAdSk9Kp1xjUO6V2DN+iBtuL63QZ8cLHiYbO3Jv4Dy+MG4fJ3Y/JvkmxW mqL67qqV68/4OU3HY+83C8Poen6m1u0qJGosTpTvaiFR854RekzI3K1js02j3ikaa9WU Hesu4hGDWk+U1b7eVMifuWg7maaeU1ydnTd+JRFeYMTltdJ0/71rP0kIpgJELFgP9HlB hS6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688463501; x=1691055501; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ERnzPIPRvWevLboQhEVq6zSzhxrqqEGbLmA9tpsiGI0=; b=SUpGBiIGLB5YBAJy1emIuhW3bkxlwzeYM44dsfonpj51pMHXbvu3pM73vkHv9eBStA xcU+NobuYZGWKLOk4eCgoeiAxSd6UXDTlMpSeVbl9Zzi9RTKWPwnLGeyIpTVmq3Y2VUE q/9weke7o9npuHMoghm20gY/Noj/ywRXtFPtoRgUmnTK14zSH/R+CZjhSMA1r2l7UoKw yjVc/ltnwjo3Ud34j6ziyoEVmKgbEneip6ix61WJGt5KGRxSNHrUmupwAP1WfO9gi7wF xydSz0lNo+4pecfdH9qAhJbuQAsQS8IvARbQ9TO045EB4/lwX315tIKgx8faFNYiN9gQ i2FQ== X-Gm-Message-State: ABy/qLbLCjlPFZPCx9dt0/73KmaKHjGNwJL97zKxuDj6avOaU/zgP8gg 4s6YJeGlHTaHYI2DO827/iSBXg== X-Google-Smtp-Source: APBJJlExmWdalCwz4mhd46wIPBv+5Ajxdam8PI8PX4rD0du+csKdm67scVujAXZWR1HmZMfM3p/34Q== X-Received: by 2002:a17:906:594b:b0:988:a632:774a with SMTP id g11-20020a170906594b00b00988a632774amr10860901ejr.27.1688463501122; Tue, 04 Jul 2023 02:38:21 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id e19-20020a170906249300b0098e4aef0791sm11602644ejb.66.2023.07.04.02.38.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jul 2023 02:38:20 -0700 (PDT) Message-ID: <1b65e8d1-d5e1-0d6b-1248-d9683be44db8@linaro.org> Date: Tue, 4 Jul 2023 11:38:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [RESEND v1 1/2] dt-binding: spi: constrain minItems of clocks and clock-names Content-Language: en-US To: William Qiu , devicetree@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Cc: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing , Linus Walleij References: <20230704092200.85401-1-william.qiu@starfivetech.com> <20230704092200.85401-2-william.qiu@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <20230704092200.85401-2-william.qiu@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On 04/07/2023 11:21, William Qiu wrote: > The SPI controller only need apb_pclk clock to work properly on JH7110 SoC, > so there add minItems whose value is equal to 1. Other platforms do not > have this constraint. > > Signed-off-by: William Qiu I don't get why this is resent, but subject prefix is still wrong. It's dt-bindings. > --- > Documentation/devicetree/bindings/spi/spi-pl022.yaml | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml > index 91e540a92faf..42bb34c39971 100644 > --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml > +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml > @@ -11,6 +11,7 @@ maintainers: > > allOf: > - $ref: spi-controller.yaml# > + - $ref: /schemas/arm/primecell.yaml# This looks unrelated, so keep it as separate commit with its own rationale. > > # We need a select here so we don't match all nodes with 'arm,primecell' > select: > @@ -34,12 +35,16 @@ properties: > maxItems: 1 > > clocks: > + minItems: 1 > maxItems: 2 > > clock-names: > - items: > - - const: sspclk > - - const: apb_pclk > + oneOf: > + - items: > + - const: apb_pclk > + - items: > + - const: sspclk > + - const: apb_pclk Are you sure that your clock is APB pclk in such case? Best regards, Krzysztof