Re: [PATCH 6/6] SPI: S3C64XX: Add new parameter to cs callback

[jassi brar <jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

On Tue, Jan 19, 2010 at 3:15 AM, Grant Likely <grant.likely@secretlab.ca> wrote:
> On Mon, Jan 18, 2010 at 2:50 AM,  <jassisinghbrar@gmail.com> wrote:
>> From: Jassi Brar <jassi.brar@samsung.com>
>>
>> Since most of the chip-selects are simply going to be like
>> gpio_set_value, it would do good to have the same callback type
>> so that it could simply be made to point at gpio_set_value.
>>
>> Signed-off-by: Jassi Brar <jassi.brar@samsung.com>
>
> This patch changes the calling arguments, but I don't see any function
> signatures changed to reflect the new parameters.  Is this going to
> break stuff?
I hope replies to your other queries will make this clear too.

In summary, only drivers/spi/spi_s3c64xx.c was pulled in your tree while
the backend platform support for this SPI driver was held back until
some changes were made.
These 6 patches update the driver for those changes suggested by my
SoC support maintainer(Ben Dooks).
I think you could simply apply these patches, because the extant driver
is useless without platform support (which has only been accepted yesterday.)

> g.
>
>> ---
>>  drivers/spi/spi_s3c64xx.c |    7 ++++---
>>  1 files changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/spi/spi_s3c64xx.c b/drivers/spi/spi_s3c64xx.c
>> index 9fa0b99..32db695 100644
>> --- a/drivers/spi/spi_s3c64xx.c
>> +++ b/drivers/spi/spi_s3c64xx.c
>> @@ -300,13 +300,14 @@ static inline void enable_cs(struct s3c64xx_spi_driver_data *sdd,
>>                if (sdd->tgl_spi != spi) { /* if last mssg on diff device */
>>                        /* Deselect the last toggled device */
>>                        cs = sdd->tgl_spi->controller_data;
>> -                       cs->set_level(spi->mode & SPI_CS_HIGH ? 0 : 1);
>> +                       cs->set_level(cs->line,
>> +                                       spi->mode & SPI_CS_HIGH ? 0 : 1);
>>                }
>>                sdd->tgl_spi = NULL;
>>        }
>>
>>        cs = spi->controller_data;
>> -       cs->set_level(spi->mode & SPI_CS_HIGH ? 1 : 0);
>> +       cs->set_level(cs->line, spi->mode & SPI_CS_HIGH ? 1 : 0);
>>  }
>>
>>  static int wait_for_xfer(struct s3c64xx_spi_driver_data *sdd,
>> @@ -386,7 +387,7 @@ static inline void disable_cs(struct s3c64xx_spi_driver_data *sdd,
>>        if (sdd->tgl_spi == spi)
>>                sdd->tgl_spi = NULL;
>>
>> -       cs->set_level(spi->mode & SPI_CS_HIGH ? 0 : 1);
>> +       cs->set_level(cs->line, spi->mode & SPI_CS_HIGH ? 0 : 1);
>>  }
>>
>>  static void s3c64xx_spi_config(struct s3c64xx_spi_driver_data *sdd)
>> --
>> 1.6.2.5
>>
>>
>
>
>
> --
> Grant Likely, B.Sc., P.Eng.
> Secret Lab Technologies Ltd.
>

------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general