From: jassi brar <jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Centelles,
Sylvain"
<sylvain.centelles-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
<spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: Purpose of the "msg->status"
Date: Mon, 15 Mar 2010 22:53:13 +0900 [thread overview]
Message-ID: <1b68c6791003150653g6f58fbd7u4c0077f01605610d@mail.gmail.com> (raw)
In-Reply-To: <2A84145621092446B6659B8A0F28E26F4245B4844E-IGOiFh9zz4x9qrmMLTLiibfspsVTdybXVpNB7YpNyf8@public.gmane.org>
On Mon, Mar 15, 2010 at 10:06 PM, Centelles, Sylvain
<sylvain.centelles-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
> Hi Baruch,
> Thx for your fast answer.
> I had seen this piece of code. But if this is the only purpose of the msg->status, then it means it's only used to give return status of the transfer after the completion.
> That mean that the only possible value will be an error code or success. The EINPROGRESS (used in the pxa2xx_spi.c for example) will never have a chance to be returned at this place, as any completion will overwrite it. Right?
> That what was confusing me...
When a xfer is submitted, the status is set by default should the xfer
exit via some un-tested path.
If the driver state machine has only fixed and tested exit points, you
perhaps don't need to set
the default status.
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
next prev parent reply other threads:[~2010-03-15 13:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 10:13 Purpose of the "msg->status" Centelles, Sylvain
[not found] ` <2A84145621092446B6659B8A0F28E26F4245B483E9-IGOiFh9zz4x9qrmMLTLiibfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2010-03-15 11:05 ` Baruch Siach
[not found] ` <20100315110553.GC11196-X57xyCW21FZ5l4KbKkTfamZHpeb/A1Y/@public.gmane.org>
2010-03-15 13:06 ` Centelles, Sylvain
[not found] ` <2A84145621092446B6659B8A0F28E26F4245B4844E-IGOiFh9zz4x9qrmMLTLiibfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2010-03-15 13:18 ` Baruch Siach
[not found] ` <20100315131822.GA32236-X57xyCW21FZ5l4KbKkTfamZHpeb/A1Y/@public.gmane.org>
2010-03-15 13:49 ` Centelles, Sylvain
[not found] ` <2A84145621092446B6659B8A0F28E26F4245B4846D-IGOiFh9zz4x9qrmMLTLiibfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2010-03-15 14:09 ` Baruch Siach
2010-03-15 13:53 ` jassi brar [this message]
[not found] ` <1b68c6791003150653g6f58fbd7u4c0077f01605610d-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-03-15 14:09 ` Centelles, Sylvain
[not found] ` <2A84145621092446B6659B8A0F28E26F4245B48476-IGOiFh9zz4x9qrmMLTLiibfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2010-03-15 14:15 ` jassi brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b68c6791003150653g6f58fbd7u4c0077f01605610d@mail.gmail.com \
--to=jassisinghbrar-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=sylvain.centelles-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).