From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40E10C77B76 for ; Thu, 20 Apr 2023 15:37:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231770AbjDTPhz (ORCPT ); Thu, 20 Apr 2023 11:37:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231200AbjDTPhy (ORCPT ); Thu, 20 Apr 2023 11:37:54 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A1CA199A for ; Thu, 20 Apr 2023 08:37:52 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id dx24so7244086ejb.11 for ; Thu, 20 Apr 2023 08:37:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682005071; x=1684597071; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ApdTWhhkzb3N6QPss2Yi29YN1Urm38DCu4SfJzo1FQI=; b=OI42D9V5yNMUvJYFnh5KZP3SfORv1nitueVJtSxwirYdvprgf4mHQfP3mWi6vxh8p7 jc6n1kvmWxPVFwZUqRp9zkDTthsv49ZKHfZE/ajqeT7rNcDTJAWlG+uuomQ7XWcc9IEu 69qmu/jgVP6qiE5E3U94y9VwfIpZmJ60lzZY/OZVUS1Q356VSOoWf0b0gvlLb0willLI +AuwkAWPd6MndKUf7NdsTNatgvsFQTn65fKFAybNM+2k41KxAP4lQl0bC1wvVHpfgAXI ssT8Bo0cqfePRtiDhsfpi/7am7YKWYfLUrq9/stle7KV6a9R+vVpQxY+glFEPtTnfT0U Cbog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682005071; x=1684597071; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ApdTWhhkzb3N6QPss2Yi29YN1Urm38DCu4SfJzo1FQI=; b=kSHWla9Oh7CUWp1jB5w8etlILhQrDc8HnCrCBtGv4IcW7WVJyBN6oJ4mZ8JKiFcTWO ufeIBNvdreoltG3ZENWpMf/N2us6lTmiqZzw0Fc4yd+iK8Afetw69LbynF5cDkbLS7K2 lF5rf8RJMVqojyz1ium/NGcpNqXaYEFfXK834MuizIFWIXUALlk2h3W7a9NVph+krdkU g/fckU3gQoJ/SbSInSCuhmz/JBGQNTGirMqasup1LufP+Ntwvzvk3BPNONTnSXshfBzd Lvm5tDHyN0n8tpLVKqKoIQNYh46lda1CocVvzyXnwk6SVv1DRnvSnIbA05yLeQThrtbE +cQA== X-Gm-Message-State: AAQBX9fN4V3Vxhj28ZiN5CBzwEqyJNoLyx3iNf8uN5YHCBCz6lkbvLo4 n1T/BMKCMYi4/0u0+3HeGUy4ew== X-Google-Smtp-Source: AKy350bolQ8RHPDEoxQ2ZB1HmmT5FLmSChLbyJX+YfSROWHK0HuITUZs/iOaI9q4WjxA9H8o4aXbrA== X-Received: by 2002:a17:906:a258:b0:947:4828:4399 with SMTP id bi24-20020a170906a25800b0094748284399mr1991837ejb.12.1682005070813; Thu, 20 Apr 2023 08:37:50 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:bcb8:77e6:8f45:4771? ([2a02:810d:15c0:828:bcb8:77e6:8f45:4771]) by smtp.gmail.com with ESMTPSA id g25-20020a170906349900b0095336e8e012sm865381ejb.176.2023.04.20.08.37.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Apr 2023 08:37:50 -0700 (PDT) Message-ID: <1da788fd-03df-1704-187e-0045876f2605@linaro.org> Date: Thu, 20 Apr 2023 17:37:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 4/4] spi: s3c64xx: support interrupt based pio mode Content-Language: en-US To: Jaewon Kim , Mark Brown , Andi Shyti , Alim Akhtar Cc: linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Chanho Park References: <20230419060639.38853-1-jaewon02.kim@samsung.com> <20230419060639.38853-5-jaewon02.kim@samsung.com> <88e74f8f-feee-159a-3048-736a5ffc13cd@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On 19/04/2023 11:45, Jaewon Kim wrote: >>> static int s3c64xx_wait_for_pio(struct s3c64xx_spi_driver_data *sdd, >>> - struct spi_transfer *xfer) >>> + struct spi_transfer *xfer, int use_irq) >>> { >>> void __iomem *regs = sdd->regs; >>> unsigned long val; >>> + unsigned long time; >>> u32 status; >>> int loops; >>> u32 cpy_len; >>> @@ -563,17 +568,24 @@ static int s3c64xx_wait_for_pio(struct s3c64xx_spi_driver_data *sdd, >>> int ms; >>> u32 tx_time; >>> >>> - /* sleep during signal transfer time */ >>> - status = readl(regs + S3C64XX_SPI_STATUS); >>> - if (RX_FIFO_LVL(status, sdd) < xfer->len) { >>> - tx_time = (xfer->len * 8 * 1000 * 1000) / sdd->cur_speed; >>> - usleep_range(tx_time / 2, tx_time); >>> - } >> You just added this code. Adding and immediately removing it, suggests >> this should be one patch. >> > This code has been moved, not removed. Move consists of remove and add. Add it in correct place since beginning. Best regards, Krzysztof