From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3342023F422 for ; Mon, 18 Aug 2025 14:31:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755527474; cv=none; b=azAnK6UetSzgdNNgxuLNvGWJJjCnN1nzdE3HKGfJ4Y+ESiifb7fy8Y9PW8y67rhxWdeEB4ui1LllPNSYhnNjhU/x/7OBk83bSHG7p1Mb+JEKc57dUVj/k1zCQeZla9gUwzyna7DqOisD4Vy5ZebBnDnM3zmCP5YX96p+F0dNyIQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755527474; c=relaxed/simple; bh=fG35iN1kFRAXE21etI8+TbfhHtzWP96Txn+0kfsGruE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Q7FOjVaizvwvTveSPMa00DulBpBRFGqZaJUAAYVKEPuizW9XpQLnTbQgK0m7K1E90e5l02B7S9EC6R0+9gacFqL3zwk+oNESKbTYDp1eMucRLo7w+XdlPaBEUdyl0Gw4Se6G4IRjr1WuZikYkxs9kV9PIvwnUiPeH7lKs6Sq4d8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=O6vEGUxU; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="O6vEGUxU" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-3b9e414ef53so4427681f8f.2 for ; Mon, 18 Aug 2025 07:31:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755527470; x=1756132270; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YqUCIFuyjgf9dWStxbEJTvtbXAyyq5gx6EE3yh2DLD8=; b=O6vEGUxUOI40VfR8RNyn8YC7qhMxeyjuuZnQ7c/OlRa6SwedjZ6xK9bTj+fU8lVlqP I0zcq5HRli7+a5AwESDnk2krCDF3LjoefYLUpAenLpy2HovMM6t1OABV780Rv2WSTRWr 6MdA+UyJEEmr6eWQh5gHZxaYihqPbwji3zU+Ux73x7/8JB98LrNLW5cCHUXoA9qlqY+W PQmi2BRK4rw9LKhM2LVhV8lzOGA4fA/2rZjBKE7JJ+cLk7NkaloMpoScNptMJkHKgBIO JKBlKh4ane7z87lBlLEepVe5mK4pee2hAG63a1MqYIRppvLuFb0orQyzSwJIu9DZfJ33 Fz2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755527470; x=1756132270; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YqUCIFuyjgf9dWStxbEJTvtbXAyyq5gx6EE3yh2DLD8=; b=RHwRRNVEHldGjiHL74zJCDvzE+SgHyI4s4il6ZKhPAf0BSCOL3gqFai3l9L6XYSgRA MqZ78cKnUt+YbQslteyHMdd3krNU9iFnN1wSjn0fQ0yoNq36I1+J642Jp/Wpqjly2RGu MiuCV2oGyhVbnpTDfOSv7D7dgFSPGYpP9ic0eYOl6p2EDbURSIgfJ4wTeWKIaybJzpqo 0FXe3D5udpNo+ZrhwerCPZkRFdq8exUsJ424ehqlGdU5GTm8sNnRyqSnupjB8PcWgTvx sibZztK4HipKEvy2l8Hd77n+NyHqb5FyBcBJLY4jovHKhX91BJyoCZYcl/bRfxRJDtQV 0wNA== X-Forwarded-Encrypted: i=1; AJvYcCU5JcJH/8RYShWkcIGoHo31G6+pinkC5Vtri8HmvhhcbTA96uQBGnrK08mkJe+/LS98u3mi+U9hKv8=@vger.kernel.org X-Gm-Message-State: AOJu0YyR1a9FHYcWWUqIorCw7Eh9eHfomaclEb754ndCEJiQxm3xwDZD YzjviaJkBnxelpSgJ6Mwea+NXrzYLqJYnpa6Ghi4zO9IcM2ifDgZfySkXIMUt1NkHuQ= X-Gm-Gg: ASbGncvJFrEioWJlgH+ElFG/+jrmsOJTMxjqOjozFRM6EoJnCnYBhXgHGIL1F2CsPS7 YxCC/+dNmT+o20ogIHP1+MDNk1RVhOL7WnHS2of1GotQHz7B5O58b9B0nAy6wtX+FOq9WBn3T5o 62e5B+e0X0SrdnPm4ijwKiVUDXaweg22r/jbzvEoZoYhjblF6aBRdT9p4Rp6ZLKLa+41/+1g22D DyjhnDu2IGyz9F2F0w04lP++e5OAF6F4e1olBHNt/X1NJgtsmGUd5kldCVWfHN90mpV1whYL7qo yLsMl5iDM8QjRp5d7xjySHGktvIc75sggOE1Lj9DdMvVxlosQ8M7+7UJhywWFojcWZOYB8pBnQD IauMWrJAetpuO0tIWiOnHbfdMj2s= X-Google-Smtp-Source: AGHT+IEIVkPMjBrXWVFI0F4OEOVQGx0ZBgi9PzSgWdLSOcLjkm3Z6slxreu6ZYNW317l5cxTvC2cUA== X-Received: by 2002:a05:6000:2289:b0:3b8:d14b:8f86 with SMTP id ffacd0b85a97d-3bb690d1f0amr9352479f8f.45.1755527470412; Mon, 18 Aug 2025 07:31:10 -0700 (PDT) Received: from [192.168.1.3] ([185.48.76.109]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3bb64d2a405sm13313387f8f.20.2025.08.18.07.31.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Aug 2025 07:31:10 -0700 (PDT) Message-ID: <1f3b68d4-e0cc-4952-a695-322ed9756b95@linaro.org> Date: Mon, 18 Aug 2025 15:31:08 +0100 Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/13] spi: spi-fsl-lpspi: Add compatible for S32G To: Frank Li Cc: Mark Brown , Clark Wang , Fugang Duan , Gao Pan , Fugang Duan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Larisa Grigore , Larisa Grigore , Ghennadi Procopciuc , Ciprianmarian Costea , s32@nxp.com, linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> <20250814-james-nxp-lpspi-v1-10-9586d7815d14@linaro.org> Content-Language: en-US From: James Clark In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 14/08/2025 7:25 pm, Frank Li wrote: > On Thu, Aug 14, 2025 at 05:06:50PM +0100, James Clark wrote: >> From: Larisa Grigore >> >> S32G doesn't have the max prescale erratum and it can query the max >> number of CS from hardware, so add those settings. > > binding doc should first patch. Create new patch serial for add S32G > support only. > > Frank I'm not sure putting the binding doc commit first would be right? That would imply it was a valid binding before it really was because the code change hasn't been made yet. Practically both are required so it doesn't really matter which way around they are. As for splitting the set into two, Mark mentioned that he was ok with a single one, so I assume that's fine? The devtype_data changes would conflict unless they were applied in the correct order anyway, implying the need for a single ordered patchset. James >> >> Signed-off-by: Larisa Grigore >> Signed-off-by: Ciprian Marian Costea >> Signed-off-by: James Clark >> --- >> drivers/spi/spi-fsl-lpspi.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c >> index 6d0138b27785..a4727ca37d90 100644 >> --- a/drivers/spi/spi-fsl-lpspi.c >> +++ b/drivers/spi/spi-fsl-lpspi.c >> @@ -159,9 +159,15 @@ static const struct fsl_lpspi_devtype_data imx7ulp_lpspi_devtype_data = { >> .query_hw_for_num_cs = false, >> }; >> >> +static struct fsl_lpspi_devtype_data s32g_lpspi_devtype_data = { >> + .prescale_err = false, >> + .query_hw_for_num_cs = true, >> +}; >> + >> static const struct of_device_id fsl_lpspi_dt_ids[] = { >> { .compatible = "fsl,imx7ulp-spi", .data = &imx7ulp_lpspi_devtype_data,}, >> { .compatible = "fsl,imx93-spi", .data = &imx93_lpspi_devtype_data,}, >> + { .compatible = "nxp,s32g2-lpspi", .data = &s32g_lpspi_devtype_data,}, >> { /* sentinel */ } >> }; >> MODULE_DEVICE_TABLE(of, fsl_lpspi_dt_ids); >> >> -- >> 2.34.1 >>