From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brownell Subject: Re: [PATCH 08/16] Blackfin SPI Driver: add a few more debug messages in useful places Date: Thu, 20 Nov 2008 12:35:29 -0800 Message-ID: <200811201235.29955.david-b@pacbell.net> References: <1226994760-4301-1-git-send-email-cooloney@kernel.org> <1226994760-4301-9-git-send-email-cooloney@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mike Frysinger To: Bryan Wu Return-path: In-Reply-To: <1226994760-4301-9-git-send-email-cooloney-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Monday 17 November 2008, Bryan Wu wrote: > From: Mike Frysinger > > Signed-off-by: Mike Frysinger > Signed-off-by: Bryan Wu Grr. I'm tired of acking with a "please provide a real patch comment". Consider all the other patches in this series that don't have patch comments as getting NAKs, for that reason. > --- > drivers/spi/spi_bfin5xx.c | 12 ++++++++++-- > 1 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/spi/spi_bfin5xx.c b/drivers/spi/spi_bfin5xx.c > index a7c8976..e293d19 100644 > --- a/drivers/spi/spi_bfin5xx.c > +++ b/drivers/spi/spi_bfin5xx.c > @@ -559,9 +559,13 @@ static irqreturn_t dma_irq_handler(int irq, void *dev_id) > struct driver_data *drv_data = dev_id; > struct chip_data *chip = drv_data->cur_chip; > struct spi_message *msg = drv_data->cur_msg; > + unsigned short dmastat = get_dma_curr_irqstat(drv_data->dma_channel); > u16 spistat = read_STAT(drv_data); > > - dev_dbg(&drv_data->pdev->dev, "in dma_irq_handler\n"); > + dev_dbg(&drv_data->pdev->dev, > + "in dma_irq_handler dmastat:0x%x spistat:0x%x\n", > + dmastat, spistat); > + > clear_dma_irqstat(drv_data->dma_channel); > > /* Wait for DMA to complete */ > @@ -631,6 +635,7 @@ static void pump_transfers(unsigned long data) > > /* Handle for abort */ > if (message->state == ERROR_STATE) { > + dev_dbg(&drv_data->pdev->dev, "transfer: we've hit an error\n"); > message->status = -EIO; > giveback(drv_data); > return; > @@ -638,6 +643,7 @@ static void pump_transfers(unsigned long data) > > /* Handle end of message */ > if (message->state == DONE_STATE) { > + dev_dbg(&drv_data->pdev->dev, "transfer: all done!\n"); > message->status = 0; > giveback(drv_data); > return; > @@ -645,6 +651,7 @@ static void pump_transfers(unsigned long data) > > /* Delay if requested at end of transfer */ > if (message->state == RUNNING_STATE) { > + dev_dbg(&drv_data->pdev->dev, "transfer: still running ...\n"); > previous = list_entry(transfer->transfer_list.prev, > struct spi_transfer, transfer_list); > if (previous->delay_usecs) > @@ -805,7 +812,8 @@ static void pump_transfers(unsigned long data) > dma_config = (RESTART | dma_width | DI_EN); > if (drv_data->rx != NULL) { > /* set transfer mode, and enable SPI */ > - dev_dbg(&drv_data->pdev->dev, "doing DMA in.\n"); > + dev_dbg(&drv_data->pdev->dev, "doing DMA in to %p (size %zx)\n", > + drv_data->rx, drv_data->len_in_bytes); > > /* invalidate caches, if needed */ > if (bfin_addr_dcachable((unsigned long) drv_data->rx)) > -- > 1.5.6.3 > > ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/