From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brownell Subject: Re: [PATCH 10/16] Blackfin SPI Driver: use the properl BIT_CTL_xxx defines Date: Thu, 20 Nov 2008 12:37:42 -0800 Message-ID: <200811201237.43180.david-b@pacbell.net> References: <1226994760-4301-1-git-send-email-cooloney@kernel.org> <1226994760-4301-11-git-send-email-cooloney@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mike Frysinger To: Bryan Wu Return-path: In-Reply-To: <1226994760-4301-11-git-send-email-cooloney-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Monday 17 November 2008, Bryan Wu wrote: > From: Mike Frysinger > > use the properl BIT_CTL_... defines rather than the internal driv > er CFG_SPI_... defines > > @@ -821,12 +821,9 @@ static void pump_transfers(unsigned long data) > (unsigned long) (drv_data->rx + > drv_data->len_in_bytes)); > > - /* clear tx reg soformer data is not shifted out */ > - write_TDBR(drv_data, 0xFFFF); > - This is unrelated to a BIT_CTL #define. It's a bug in either the patch or its comment. > dma_config |= WNR; > dma_start_addr = (unsigned long)drv_data->rx; ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/