linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Feng Tang <feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Jean-Hugues Deschenes
	<jean-hugues.deschenes-YGVykHU+fedBDgjK7y7TUQ@public.gmane.org>
Cc: spi-devel-list
	<spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	David Brownell
	<dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [PATCH 3/3] spi: dw_spi: refine the IRQ mode working flow
Date: Thu, 21 Jan 2010 10:47:26 +0800	[thread overview]
Message-ID: <20100121104726.0fea94e5@feng-desktop> (raw)
In-Reply-To: <4B56FA93.1030507-YGVykHU+fedBDgjK7y7TUQ@public.gmane.org>

On Wed, 20 Jan 2010 20:44:03 +0800
Jean-Hugues Deschenes <jean-hugues.deschenes-YGVykHU+fedBDgjK7y7TUQ@public.gmane.org> wrote:

>
> >>     
> >
> > For FIFO depth, it depends on each specific implementation based on
> > DW core, and interface driver would better set it. If fifo_len is
> > not set in IRQ mode, core driver will set 0 as the TX interrupt
> > threshold, which will only trigger the TXE IRQ when the TX FIFO is
> > fully empty. This is my design thought. 
> I'm sorry; At first, I was under the impression that it referred to a 
> software FIFO.
> ...So could this be auto-detected from the [RT]XFTLR registers, then?
> 

Yep, really a good idea, from the HW spec, the depth could be detected
from [RT}XTLR, will submit a patch for this.

Thanks,
Feng

------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev

      parent reply	other threads:[~2010-01-21  2:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-19  3:20 [PATCH 3/3] spi: dw_spi: refine the IRQ mode working flow Feng Tang
2010-01-19 14:20 ` Jean-Hugues Deschenes
     [not found]   ` <4B55BFC5.506-YGVykHU+fedBDgjK7y7TUQ@public.gmane.org>
2010-01-20  3:18     ` Feng Tang
2010-01-20 12:44       ` Jean-Hugues Deschenes
     [not found]         ` <4B56FA93.1030507-YGVykHU+fedBDgjK7y7TUQ@public.gmane.org>
2010-01-21  2:47           ` Feng Tang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100121104726.0fea94e5@feng-desktop \
    --to=feng.tang-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=jean-hugues.deschenes-YGVykHU+fedBDgjK7y7TUQ@public.gmane.org \
    --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).