Re: PATCH[V2 1/3]: Update Platform files for SPI

[Tony Lindgren <tony@atomide.com>]

* Grant Likely <grant.likely@secretlab.ca> [100218 08:26]:
> On Tue, Feb 9, 2010 at 3:25 PM, Tony Lindgren <tony@atomide.com> wrote:
> > * Hemanth V <hemanthv@ti.com> [100203 02:19]:
> >> From ee48142ddc43129a21676dbb56a83e3e7d8063de Mon Sep 17 00:00:00 2001
> >> From: Hemanth V <hemanthv@ti.com>
> >> Date: Fri, 27 Nov 2009 14:22:30 +0530
> >> Subject: [PATCH] Update platform files
> >>
> >> This patch updates platform files for
> >> fifo, slave support
> >>
> >> Signed-off-by: Hemanth V <hemanthv@ti.com>
> >
> > This should get merged via the spi-devel list with the other patches.
> >
> > Acked-by: Tony Lindgren <tony@atomide.com>
> 
> Tony, do you want me to add your acked-by to patches 2 & 3?

No thanks, I've only looked at them briefly.
 
> Also, what is your feeling about patch 3/3, spi slave support.  spi
> slave usage model is still a matter under debate, but that patch
> doesn't touch core spi code, so I'm okay to merge it as a
> driver-specific feature.  However, I'm not convinced that it is
> actually a useful patch to merge yet, so I'll defer to you on this
> one.  Thoughts?

Up to you to decide. But here's my experience so far..

Based on my experience if temporary hacks are merged, then nobody
bothers to clean them up properly afterwards and the clean-up task
unfairly falls on the maintainer.

So IMHO, hacks like that are better floating on the mailing list
until they're properly done. It's best to concentrate on getting
the core things done right to make long term support easier.

Regards,

Tony