linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Balbi <me@felipebalbi.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Felipe Balbi <me@felipebalbi.com>,
	Scott Ellis <scott@jumpnowtek.com>,
	spi-devel-general@lists.sourceforge.net,
	David Brownell <dbrownell@users.sourceforge.net>,
	Grant Likely <grant.likely@secretlab.ca>,
	Andrew Morton <akpm@linux-foundation.org>,
	Roman Tereshonkov <roman.tereshonkov@nokia.com>,
	linux-omap@vger.kernel.org,
	Aaro Koskinen <Aaro.Koskinen@nokia.com>,
	Kevin Hilman <khilman@deeprootsystems.com>
Subject: Re: [PATCH 2/6 Revised] SPI omap2_mcspi: Add max_clk_div field to mcspi platform config
Date: Mon, 15 Mar 2010 21:31:58 +0200	[thread overview]
Message-ID: <20100315193158.GF25452@gandalf> (raw)
In-Reply-To: <20100315192909.GC2900@atomide.com>

Hi,

On Mon, Mar 15, 2010 at 12:29:10PM -0700, Tony Lindgren wrote:
> > could be, but we already have separated clk, pm, cpuidle, mux and soon
> > to become devices. So pretty much the base support is already splitted,
> > then why not completely avoiding ifdefs also with dma (which today is
> > full of ifdefs and could be converted to a platform_device also).
> 
> Yeah there are tons of things that should be fixed and split into
> platform_data and generic code. At least gpio.c, dma.c and i2c-omap.c
> need some serious work.

problem with those guys is that they're used all over the place so any
changes there would always be extremelly intrusive and are prone to
cause regressions :-(

I could try to allocate some time to play with dma.c but I can only test
on omap3 since my n810 isn't mount root on mmc, maybe I screwed up
something and can't remember what :-s if you happen to have tips, I'm
all ears. The thing is rebooting with "mbus" bootreason. I'll have to
dig up some legacy docs to figure out what's that.

-- 
balbi

  reply	other threads:[~2010-03-15 19:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-12 15:21 [PATCH 2/6] SPI omap2_mcspi: Add max_clk_div field to mcspi platform config Scott Ellis
2010-03-12 17:21 ` Tony Lindgren
2010-03-14 17:25   ` [PATCH 2/6 Revised] " Scott Ellis
2010-03-15 16:32     ` Tony Lindgren
2010-03-15 18:03       ` Felipe Balbi
2010-03-15 18:52         ` Tony Lindgren
2010-03-15 19:16           ` Felipe Balbi
2010-03-15 19:29             ` Tony Lindgren
2010-03-15 19:31               ` Felipe Balbi [this message]
2010-03-15 20:06                 ` Tony Lindgren
2010-03-15 20:30       ` Scott Ellis
2010-03-15 21:02         ` Tony Lindgren
2010-03-19 19:46           ` Scott Ellis
2010-03-19 20:38             ` Tony Lindgren
2010-05-24 14:26               ` Scott Ellis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100315193158.GF25452@gandalf \
    --to=me@felipebalbi.com \
    --cc=Aaro.Koskinen@nokia.com \
    --cc=akpm@linux-foundation.org \
    --cc=dbrownell@users.sourceforge.net \
    --cc=grant.likely@secretlab.ca \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=roman.tereshonkov@nokia.com \
    --cc=scott@jumpnowtek.com \
    --cc=spi-devel-general@lists.sourceforge.net \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).