Re: [PATCH 2/6 Revised] SPI omap2_mcspi: Add max_clk_div field to mcspi platform config

[Tony Lindgren <tony@atomide.com>]

* Felipe Balbi <me@felipebalbi.com> [100315 12:30]:
> Hi,
> 
> On Mon, Mar 15, 2010 at 12:29:10PM -0700, Tony Lindgren wrote:
> > > could be, but we already have separated clk, pm, cpuidle, mux and soon
> > > to become devices. So pretty much the base support is already splitted,
> > > then why not completely avoiding ifdefs also with dma (which today is
> > > full of ifdefs and could be converted to a platform_device also).
> > 
> > Yeah there are tons of things that should be fixed and split into
> > platform_data and generic code. At least gpio.c, dma.c and i2c-omap.c
> > need some serious work.
> 
> problem with those guys is that they're used all over the place so any
> changes there would always be extremelly intrusive and are prone to
> cause regressions :-(

Well it's not too hard, just need to be careful and do it in small
patches and test carefully between each patch :)

> I could try to allocate some time to play with dma.c but I can only test
> on omap3 since my n810 isn't mount root on mmc, maybe I screwed up
> something and can't remember what :-s if you happen to have tips, I'm
> all ears. The thing is rebooting with "mbus" bootreason. I'll have to
> dig up some legacy docs to figure out what's that.

For some reason only one of the MMC slots works on both n800 and n810,
maybe some menelaus slot switching issue. So you need to try mounting
root on the external card on n810 for now until somebody figures out
the problem.

Tony