From: Anton Vorontsov <cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Joakim Tjernlund
<Joakim.Tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] spi: spi_mpc8xxx.c: Fix QE mode Litte Endian
Date: Fri, 14 May 2010 16:22:18 +0400 [thread overview]
Message-ID: <20100514122218.GA24394@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1273828467-4593-1-git-send-email-Joakim.Tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org>
On Fri, May 14, 2010 at 11:14:26AM +0200, Joakim Tjernlund wrote:
> QE mode uses Little Endian so words > 8 bits are byte swapped.
> Workaround this by always enforcing wordsize 8 for words
> > 8 bits. Unfortunately this will not work for LSB transfers
> where wordsize is > 8 bits so disable these for now.
>
> Also move the different quirks into its own function to keep
> mpc8xxx_spi_setup_transfer() sane.
>
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org>
> ---
Looks OK, thanks!
Acked-by: Anton Vorontsov <cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
--
Anton Vorontsov
email: cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
irc://irc.freenode.net/bd2
------------------------------------------------------------------------------
prev parent reply other threads:[~2010-05-14 12:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-14 9:14 [PATCH] spi: spi_mpc8xxx.c: Fix QE mode Litte Endian Joakim Tjernlund
[not found] ` <1273828467-4593-1-git-send-email-Joakim.Tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org>
2010-05-14 9:14 ` [PATCH] spi: spidev_test.c: Make transfer size suitable for wordsize 32 Joakim Tjernlund
[not found] ` <1273828467-4593-2-git-send-email-Joakim.Tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org>
2010-05-14 12:22 ` Anton Vorontsov
[not found] ` <20100514122239.GB24394-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
2010-05-22 8:39 ` Grant Likely
[not found] ` <AANLkTinWmX39klqQvBPpZY44YdTK3ESb6uu6EomW7fZb-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-05-22 14:34 ` Joakim Tjernlund
[not found] ` <OF066BF1BA.ACBE06A8-ONC125772B.004FB6E4-C125772B.00501681-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org>
2010-05-25 19:41 ` Grant Likely
[not found] ` <AANLkTinZUXo2fjD6ijdTWfDhom6TF6e0goiXuVUshPxN-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-05-25 20:28 ` Joakim Tjernlund
2010-05-14 12:22 ` Anton Vorontsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100514122218.GA24394@oksana.dev.rtsoft.ru \
--to=cbouatmailru-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=Joakim.Tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).