From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Vorontsov Subject: Re: [PATCH] spi: spi_mpc8xxx.c: Fix QE mode Litte Endian Date: Fri, 14 May 2010 16:22:18 +0400 Message-ID: <20100514122218.GA24394@oksana.dev.rtsoft.ru> References: <1273828467-4593-1-git-send-email-Joakim.Tjernlund@transmode.se> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Joakim Tjernlund Return-path: Content-Disposition: inline In-Reply-To: <1273828467-4593-1-git-send-email-Joakim.Tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Fri, May 14, 2010 at 11:14:26AM +0200, Joakim Tjernlund wrote: > QE mode uses Little Endian so words > 8 bits are byte swapped. > Workaround this by always enforcing wordsize 8 for words > > 8 bits. Unfortunately this will not work for LSB transfers > where wordsize is > 8 bits so disable these for now. > > Also move the different quirks into its own function to keep > mpc8xxx_spi_setup_transfer() sane. > > Signed-off-by: Joakim Tjernlund > --- Looks OK, thanks! Acked-by: Anton Vorontsov -- Anton Vorontsov email: cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org irc://irc.freenode.net/bd2 ------------------------------------------------------------------------------