[PATCH] spi: spi_mpc8xxx.c: Do not use map_tx_dma to unmap rx_dma

[PATCH] spi: spi_mpc8xxx.c: Do not use map_tx_dma to unmap rx_dma

[Joakim Tjernlund]

This fixes a typo were map_tx_dma is used instead of
map_rx_dma, casing the driver to unmap rx_dma when it
shouldn't.

Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org>
---
 drivers/spi/spi_mpc8xxx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/spi/spi_mpc8xxx.c b/drivers/spi/spi_mpc8xxx.c
index c85dbbb..2d54020 100644
--- a/drivers/spi/spi_mpc8xxx.c
+++ b/drivers/spi/spi_mpc8xxx.c
@@ -514,7 +514,7 @@ static void mpc8xxx_spi_cpm_bufs_complete(struct mpc8xxx_spi *mspi)
 
 	if (mspi->map_tx_dma)
 		dma_unmap_single(dev, mspi->tx_dma, t->len, DMA_TO_DEVICE);
-	if (mspi->map_tx_dma)
+	if (mspi->map_rx_dma)
 		dma_unmap_single(dev, mspi->rx_dma, t->len, DMA_FROM_DEVICE);
 	mspi->xfer_in_progress = NULL;
 }
-- 
1.6.4.4


------------------------------------------------------------------------------

Re: [PATCH] spi: spi_mpc8xxx.c: Do not use map_tx_dma to unmap rx_dma

[Anton Vorontsov]

On Mon, May 17, 2010 at 03:17:10PM +0200, Joakim Tjernlund wrote:
> This fixes a typo were map_tx_dma is used instead of
> map_rx_dma, casing the driver to unmap rx_dma when it
> shouldn't.
> 
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org>

Acked-by: Anton Vorontsov <cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Thanks!

> ---
>  drivers/spi/spi_mpc8xxx.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/spi/spi_mpc8xxx.c b/drivers/spi/spi_mpc8xxx.c
> index c85dbbb..2d54020 100644
> --- a/drivers/spi/spi_mpc8xxx.c
> +++ b/drivers/spi/spi_mpc8xxx.c
> @@ -514,7 +514,7 @@ static void mpc8xxx_spi_cpm_bufs_complete(struct mpc8xxx_spi *mspi)
>  
>  	if (mspi->map_tx_dma)
>  		dma_unmap_single(dev, mspi->tx_dma, t->len, DMA_TO_DEVICE);
> -	if (mspi->map_tx_dma)
> +	if (mspi->map_rx_dma)
>  		dma_unmap_single(dev, mspi->rx_dma, t->len, DMA_FROM_DEVICE);
>  	mspi->xfer_in_progress = NULL;
>  }
> -- 
> 1.6.4.4

-- 
Anton Vorontsov
email: cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
irc://irc.freenode.net/bd2

------------------------------------------------------------------------------

Re: [PATCH] spi: spi_mpc8xxx.c: Do not use map_tx_dma to unmap rx_dma

[Joakim Tjernlund]

Anton Vorontsov <cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote on 2010/05/17 15:22:54:
>
> On Mon, May 17, 2010 at 03:17:10PM +0200, Joakim Tjernlund wrote:
> > This fixes a typo were map_tx_dma is used instead of
> > map_rx_dma, casing the driver to unmap rx_dma when it
> > shouldn't.
> >
> > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org>
>
> Acked-by: Anton Vorontsov <cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> Thanks!

Hi Grant

I havn't seen any activity towards getting my patches into Linus tree, forgotten?


------------------------------------------------------------------------------

Re: [PATCH] spi: spi_mpc8xxx.c: Do not use map_tx_dma to unmap rx_dma

[Grant Likely]

On Fri, May 21, 2010 at 11:23 AM, Joakim Tjernlund
<joakim.tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org> wrote:
> Anton Vorontsov <cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote on 2010/05/17 15:22:54:
>>
>> On Mon, May 17, 2010 at 03:17:10PM +0200, Joakim Tjernlund wrote:
>> > This fixes a typo were map_tx_dma is used instead of
>> > map_rx_dma, casing the driver to unmap rx_dma when it
>> > shouldn't.
>> >
>> > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org>
>>
>> Acked-by: Anton Vorontsov <cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>
>> Thanks!
>
> Hi Grant
>
> I havn't seen any activity towards getting my patches into Linus tree, forgotten?

Not forgotten.  Just digging myself out from under the backlog due to
travel.  I'm getting it sorted out now.

g.

------------------------------------------------------------------------------