linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Feng Tang <feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
Cc: "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
	<spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: controller_data handling through spidev.c
Date: Wed, 1 Sep 2010 09:55:54 +0800	[thread overview]
Message-ID: <20100901095554.5c023cc6@feng-i7> (raw)
In-Reply-To: <362524.36146.qm-g47maUHHHF8A0QRgWO9Mevu2YVrzzGjVVpNB7YpNyf8@public.gmane.org>


> 
> It's a sibling to the platform_data field, and
> should be set up with that.  Neither one should
> be assigned or understood by protocol drivers.


> 
> Historically, controller_data was used ISTR to
> cope with tuning that the PXA SPI controller
> required (DMA etc).  Most controllers should
> have no need for it.
> 

DW spi driver is also using the controller data, but as you said
protocol driver itself doesn't need set it. Platform code where
that spi device is registered (by spi_register_board_info) should
set up the controller data.

Thanks,
Feng

------------------------------------------------------------------------------
This SF.net Dev2Dev email is sponsored by:

Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd

  parent reply	other threads:[~2010-09-01  1:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-31 13:58 controller_data handling through spidev.c Soulard, MathieuX
     [not found] ` <9F3EABD6E3419B4C81F34EAABB4D4018810CF7F496-IGOiFh9zz4x9qrmMLTLiibfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2010-08-31 15:05   ` David Brownell
     [not found]     ` <362524.36146.qm-g47maUHHHF8A0QRgWO9Mevu2YVrzzGjVVpNB7YpNyf8@public.gmane.org>
2010-09-01  1:55       ` Feng Tang [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-08-31 14:25 Soulard, MathieuX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100901095554.5c023cc6@feng-i7 \
    --to=feng.tang-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org \
    --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).