From mboxrd@z Thu Jan 1 00:00:00 1970 From: Feng Tang Subject: Re: controller_data handling through spidev.c Date: Wed, 1 Sep 2010 09:55:54 +0800 Message-ID: <20100901095554.5c023cc6@feng-i7> References: <9F3EABD6E3419B4C81F34EAABB4D4018810CF7F496@irsmsx501.ger.corp.intel.com> <362524.36146.qm@web180304.mail.gq1.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" To: David Brownell Return-path: In-Reply-To: <362524.36146.qm-g47maUHHHF8A0QRgWO9Mevu2YVrzzGjVVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org > > It's a sibling to the platform_data field, and > should be set up with that. Neither one should > be assigned or understood by protocol drivers. > > Historically, controller_data was used ISTR to > cope with tuning that the PXA SPI controller > required (DMA etc). Most controllers should > have no need for it. > DW spi driver is also using the controller data, but as you said protocol driver itself doesn't need set it. Platform code where that spi device is registered (by spi_register_board_info) should set up the controller data. Thanks, Feng ------------------------------------------------------------------------------ This SF.net Dev2Dev email is sponsored by: Show off your parallel programming skills. Enter the Intel(R) Threading Challenge 2010. http://p.sf.net/sfu/intel-thread-sfd