From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Linus Walleij <linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Lukasz Baj <lukasz.baj-++hxYGjEMp0AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] SPI: move PL022 probe call to subsys_initcall()
Date: Wed, 8 Sep 2010 22:53:44 -0600 [thread overview]
Message-ID: <20100909045344.GC11833@angua.secretlab.ca> (raw)
In-Reply-To: <1283763732-19419-1-git-send-email-linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
On Mon, Sep 06, 2010 at 11:02:12AM +0200, Linus Walleij wrote:
> The PL022 SPI bus is sometimes used for early stuff like
> regulators that need to be present at module_init() time, so
> we move this to a subsys_initcall().
>
> Cc: Lukasz Baj <lukasz.baj-++hxYGjEMp0AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Linus Walleij <linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
Applied, thanks.
Note on the subject line: The preferred form for spi patches is:
spi[/chip]: <description>
'spi' in the header and the optional driver name are both lowercase.
I fix patches up to match this form, but it is less work for me when I
don't have to.
g.
> ---
> drivers/spi/amba-pl022.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/spi/amba-pl022.c b/drivers/spi/amba-pl022.c
> index 3db5402..f958072 100644
> --- a/drivers/spi/amba-pl022.c
> +++ b/drivers/spi/amba-pl022.c
> @@ -2324,7 +2324,7 @@ static int __init pl022_init(void)
> return amba_driver_register(&pl022_driver);
> }
>
> -module_init(pl022_init);
> +subsys_initcall(pl022_init);
>
> static void __exit pl022_exit(void)
> {
> --
> 1.6.3.3
>
------------------------------------------------------------------------------
This SF.net Dev2Dev email is sponsored by:
Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd
next prev parent reply other threads:[~2010-09-09 4:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-06 9:02 [PATCH] SPI: move PL022 probe call to subsys_initcall() Linus Walleij
[not found] ` <1283763732-19419-1-git-send-email-linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
2010-09-09 4:53 ` Grant Likely [this message]
2010-09-09 8:05 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100909045344.GC11833@angua.secretlab.ca \
--to=grant.likely-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
--cc=linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=lukasz.baj-++hxYGjEMp0AvxtiuMwx3w@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).