From: Feng Tang <feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
Cc: "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
<spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [PATCH] spi: add a bits_per_word to struct spi_board_info
Date: Thu, 9 Sep 2010 14:06:14 +0800 [thread overview]
Message-ID: <20100909140614.1ee4703e@feng-i7> (raw)
In-Reply-To: <570796.22556.qm-g47maUHHHF8P4eY3Ra60wvu2YVrzzGjVVpNB7YpNyf8@public.gmane.org>
On Thu, 9 Sep 2010 11:48:22 +0800
David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org> wrote:
> You know, in retrospect, I shouldn't have put
> most of those SPI device setup params into the
> board setup data.
>
> There's one which MUST be there: polarity of
> the chip select line. The rest seem like they
> could (and arguably should) all be handled by
> driver-specific params. (Possible exception:
> clock rate, which sometimes matters even when
> chips are not selected).
>
> At any rate, adding MORE driver-specific params
> (like bits-per-word) to board setup data seems
> like the wrong direction to go..
Agree. Thank you two for helping me get an overall picture of
configuring these parameters.
-Feng
------------------------------------------------------------------------------
This SF.net Dev2Dev email is sponsored by:
Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd
prev parent reply other threads:[~2010-09-09 6:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 6:24 [PATCH] spi: add a bits_per_word to struct spi_board_info Feng Tang
[not found] ` <1283322289-2545-1-git-send-email-feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2010-09-01 15:10 ` Grant Likely
[not found] ` <220308.75070.qm@web180310.mail.gq1.yahoo.com>
[not found] ` <220308.75070.qm-4JhmkcZgSkk/JfqJOfUXs/u2YVrzzGjVVpNB7YpNyf8@public.gmane.org>
2010-09-02 2:01 ` Feng Tang
2010-09-02 5:23 ` David Brownell
[not found] ` <930634.1250.qm-4JhmkcZgSkk/JfqJOfUXs/u2YVrzzGjVVpNB7YpNyf8@public.gmane.org>
2010-09-02 6:13 ` Feng Tang
2010-09-08 20:21 ` Grant Likely
[not found] ` <20100908202159.GG7065-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
2010-09-09 3:14 ` Feng Tang
2010-09-09 3:18 ` Grant Likely
[not found] ` <20100909031827.GA10389-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
2010-09-09 3:48 ` David Brownell
[not found] ` <570796.22556.qm-g47maUHHHF8P4eY3Ra60wvu2YVrzzGjVVpNB7YpNyf8@public.gmane.org>
2010-09-09 4:36 ` Grant Likely
2010-09-09 6:06 ` Feng Tang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100909140614.1ee4703e@feng-i7 \
--to=feng.tang-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).