From mboxrd@z Thu Jan 1 00:00:00 1970 From: Feng Tang Subject: Re: [PATCH] spi: add a bits_per_word to struct spi_board_info Date: Thu, 9 Sep 2010 14:06:14 +0800 Message-ID: <20100909140614.1ee4703e@feng-i7> References: <20100909031827.GA10389@angua.secretlab.ca> <570796.22556.qm@web180308.mail.gq1.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" To: David Brownell Return-path: In-Reply-To: <570796.22556.qm-g47maUHHHF8P4eY3Ra60wvu2YVrzzGjVVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Thu, 9 Sep 2010 11:48:22 +0800 David Brownell wrote: > You know, in retrospect, I shouldn't have put > most of those SPI device setup params into the > board setup data. > > There's one which MUST be there: polarity of > the chip select line. The rest seem like they > could (and arguably should) all be handled by > driver-specific params. (Possible exception: > clock rate, which sometimes matters even when > chips are not selected). > > At any rate, adding MORE driver-specific params > (like bits-per-word) to board setup data seems > like the wrong direction to go.. Agree. Thank you two for helping me get an overall picture of configuring these parameters. -Feng ------------------------------------------------------------------------------ This SF.net Dev2Dev email is sponsored by: Show off your parallel programming skills. Enter the Intel(R) Threading Challenge 2010. http://p.sf.net/sfu/intel-thread-sfd