From: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
To: Cyril Chemparathy <cyril-l0cyMroinI0@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org,
dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org
Subject: Re: [PATCH 07/12] davinci: add tnetv107x evm regulators
Date: Thu, 14 Oct 2010 22:05:16 +0100 [thread overview]
Message-ID: <20101014210516.GC14479@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1287081535-2864-8-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
On Thu, Oct 14, 2010 at 02:38:50PM -0400, Cyril Chemparathy wrote:
> + {
> + .num_consumer_supplies = ARRAY_SIZE(usb_consumers),
> + .consumer_supplies = usb_consumers,
> + .constraints = {
> + .name = "USB",
> + .min_uV = 5000000,
> + .max_uV = 5000000,
> + .min_uA = 200000,
> + .max_uA = 1000000,
Are you *sure* about the min_uA here - what would be the goal of
enforcing a minimum current draw? For a voltage regulator current limit
usually only an upper limit would be specified. The same applies to
several other machine drivers in the series.
next prev parent reply other threads:[~2010-10-14 21:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 18:38 [PATCH 00/12] tnetv107x ssp driver stack Cyril Chemparathy
[not found] ` <1287081535-2864-1-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-10-14 18:38 ` [PATCH 01/12] misc: add driver for sequencer serial port Cyril Chemparathy
[not found] ` <1287081535-2864-2-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-10-16 5:00 ` Grant Likely
[not found] ` <20101016050055.GH21170-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
2010-10-18 13:56 ` Cyril Chemparathy
[not found] ` <4CBC520B.9070502-l0cyMroinI0@public.gmane.org>
2010-10-18 14:59 ` Grant Likely
2010-10-14 18:38 ` [PATCH 02/12] davinci: add tnetv107x ssp platform device Cyril Chemparathy
2010-10-14 18:38 ` [PATCH 03/12] davinci: add ssp config for tnetv107x evm board Cyril Chemparathy
2010-10-14 18:38 ` [PATCH 04/12] spi: add ti-ssp spi master driver Cyril Chemparathy
[not found] ` <1287081535-2864-5-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-10-16 5:05 ` Grant Likely
2010-10-14 18:38 ` [PATCH 05/12] davinci: add spi devices on tnetv107x evm Cyril Chemparathy
2010-10-14 18:38 ` [PATCH 06/12] regulator: add driver for tps6524x regulator Cyril Chemparathy
[not found] ` <1287081535-2864-7-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-10-14 21:03 ` Mark Brown
[not found] ` <20101014210323.GB14479-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2010-10-18 12:50 ` Cyril Chemparathy
2010-10-16 10:00 ` Mark Brown
2010-10-14 18:38 ` [PATCH 07/12] davinci: add tnetv107x evm regulators Cyril Chemparathy
[not found] ` <1287081535-2864-8-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-10-14 21:05 ` Mark Brown [this message]
2010-10-14 18:38 ` [PATCH 08/12] gpio: add ti-ssp virtual gpio driver Cyril Chemparathy
2010-10-14 18:38 ` [PATCH 09/12] davinci: add tnetv107x evm ti-ssp gpio device Cyril Chemparathy
2010-10-14 18:38 ` [PATCH 10/12] backlight: add support for tps6116x controller Cyril Chemparathy
2010-10-14 18:38 ` [PATCH 11/12] davinci: add tnetv107x evm backlight device Cyril Chemparathy
2010-10-14 18:38 ` [PATCH 12/12] davinci: add tnetv107x evm i2c eeprom device Cyril Chemparathy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101014210516.GC14479@opensource.wolfsonmicro.com \
--to=broonie-yzvpicuk2aatku/dhu1wvuem+bqzidxxqq4iyu8u01e@public.gmane.org \
--cc=cyril-l0cyMroinI0@public.gmane.org \
--cc=davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org \
--cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).