From: Grant Likely <grant.likely@secretlab.ca>
To: Kumar Gala <kumar.gala@freescale.com>
Cc: dedekind1@gmail.com, David Brownell <david-b@pacbell.net>,
Linuxppc-dev list <linuxppc-dev@ozlabs.org>,
linux-mtd@lists.infradead.org,
spi-devel-general@lists.sourceforge.net,
Mingkai Hu <Mingkai.hu@freescale.com>
Subject: Re: [PATCH v4 5/5] mtd: m25p80: add support to parse the partitions by OF node
Date: Fri, 22 Oct 2010 01:39:44 -0600 [thread overview]
Message-ID: <20101022073944.GE8205@angua.secretlab.ca> (raw)
In-Reply-To: <3AE1F37D-F328-40EF-8B35-F94CC074D384@freescale.com>
On Fri, Oct 22, 2010 at 01:01:12AM -0500, Kumar Gala wrote:
>
> On Oct 17, 2010, at 2:44 AM, Artem Bityutskiy wrote:
>
> > On Sat, 2010-10-16 at 19:05 -0600, Grant Likely wrote:
> >> On Sat, Oct 16, 2010 at 1:17 PM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> >>> On Tue, 2010-10-12 at 18:18 +0800, Mingkai Hu wrote:
> >>>> Signed-off-by: Mingkai Hu <Mingkai.hu@freescale.com>
> >>>> Acked-by: Grant Likely <grant.likely@secretlab.ca>
> >>>> ---
> >>>> v4:
> >>>> - Updated to latest kernel base(Linux 2.6.36-rc7).
> >>>> - Made changes according to Grant's comments.
> >>>
> >>> Looks good to me, pushed to l2-mtd-2.6.git, thanks.
> >>
> >> Wait! It will break whenever CONFIG_OF is not set. I broke
> >> linux-next with this patch. It can be solved by wrapping the block
> >> with #ifdef CONFIG_OF, but I'd like to find a better solution.
> >
> > OK, removed.
>
> Grant, poke. Would like to see this either resolved or have this patch go in for .37 w/CONFIG_OF and fix properly for .38.
>
Okay, I've added it to my devicetree/next branch with the fix.
Assuming no last minute linux-next problems, I'll be asking Linus to
pull that branch early next week.
g.
next prev parent reply other threads:[~2010-10-22 7:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 10:18 [PATCH v4 0/5] refactor spi_mpc8xxx.c and add eSPI controller support Mingkai Hu
[not found] ` <1286878714-13090-1-git-send-email-Mingkai.hu-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2010-10-12 10:18 ` [PATCH v4 1/5] spi/mpc8xxx: rename spi_mpc8xxx.c to spi_fsl_spi.c Mingkai Hu
[not found] ` <1286878714-13090-2-git-send-email-Mingkai.hu-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2010-10-12 10:18 ` [PATCH v4 2/5] spi/mpc8xxx: refactor the common code for SPI/eSPI controller Mingkai Hu
[not found] ` <1286878714-13090-3-git-send-email-Mingkai.hu-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2010-10-12 10:18 ` [PATCH v4 3/5] eSPI: add eSPI controller support Mingkai Hu
2010-10-12 10:18 ` [PATCH v4 4/5] powerpc/of: add eSPI controller dts bindings and DTS modification Mingkai Hu
[not found] ` <1286878714-13090-5-git-send-email-Mingkai.hu-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2010-10-12 10:18 ` [PATCH v4 5/5] mtd: m25p80: add support to parse the partitions by OF node Mingkai Hu
2010-10-13 3:44 ` Grant Likely
2010-10-16 19:17 ` Artem Bityutskiy
2010-10-17 1:05 ` Grant Likely
2010-10-17 7:44 ` Artem Bityutskiy
2010-10-22 6:01 ` Kumar Gala
2010-10-22 7:39 ` Grant Likely [this message]
2010-10-13 3:41 ` [PATCH v4 4/5] powerpc/of: add eSPI controller dts bindings and DTS modification Grant Likely
[not found] ` <1286878714-13090-4-git-send-email-Mingkai.hu-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2010-10-13 3:41 ` [PATCH v4 3/5] eSPI: add eSPI controller support Grant Likely
2010-10-13 3:41 ` [PATCH v4 2/5] spi/mpc8xxx: refactor the common code for SPI/eSPI controller Grant Likely
2010-10-13 3:40 ` [PATCH v4 1/5] spi/mpc8xxx: rename spi_mpc8xxx.c to spi_fsl_spi.c Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101022073944.GE8205@angua.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=Mingkai.hu@freescale.com \
--cc=david-b@pacbell.net \
--cc=dedekind1@gmail.com \
--cc=kumar.gala@freescale.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).