Re: [PATCH] spi: fixed some core weirdness

[Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>]

On Thu, Oct 21, 2010 at 09:06:44PM +0200, Linus Walleij wrote:
> Those things in the SPI core just strike me as particularly odd:
> dev_dbg() used in an obvious error branch, and then two hardcoded
> strings passed in as parameters.
> 
> Signed-off-by: Linus Walleij <linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>

Merged, thanks.

I ready David's nack, but We're quibbling over *bytes* in the single
digits in a multi-megabyte kernel.  The total size of printk messages
is indeed a problem, but it isn't going to be solved by the kind of
micro-optimizations employed here.

I have dropped the dev_dbg->dev_err hunk though.

g.


> ---
>  drivers/spi/spi.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
> index b5a78a1..fcaa200 100644
> --- a/drivers/spi/spi.c
> +++ b/drivers/spi/spi.c
> @@ -300,16 +300,16 @@ int spi_add_device(struct spi_device *spi)
>  	 */
>  	status = spi_setup(spi);
>  	if (status < 0) {
> -		dev_err(dev, "can't %s %s, status %d\n",
> -				"setup", dev_name(&spi->dev), status);
> +		dev_err(dev, "can't setup %s, status %d\n",
> +				dev_name(&spi->dev), status);
>  		goto done;
>  	}
>  
>  	/* Device may be bound to an active driver when this returns */
>  	status = device_add(&spi->dev);
>  	if (status < 0)
> -		dev_err(dev, "can't %s %s, status %d\n",
> -				"add", dev_name(&spi->dev), status);
> +		dev_err(dev, "can't add %s, status %d\n",
> +				dev_name(&spi->dev), status);
>  	else
>  		dev_dbg(dev, "registered child %s\n", dev_name(&spi->dev));
>  
> @@ -652,7 +652,7 @@ int spi_setup(struct spi_device *spi)
>  	 */
>  	bad_bits = spi->mode & ~spi->master->mode_bits;
>  	if (bad_bits) {
> -		dev_dbg(&spi->dev, "setup: unsupported mode bits %x\n",
> +		dev_err(&spi->dev, "setup: unsupported mode bits %x\n",
>  			bad_bits);
>  		return -EINVAL;
>  	}
> -- 
> 1.6.3.3
> 

------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store 
http://p.sf.net/sfu/nokia-dev2dev