From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Richard Genoud <richard.genoud@gmail.com>
Cc: spi-devel-general@lists.sourceforge.net,
David Brownell <dbrownell@users.sourceforge.net>,
Grant Likely <grant.likely@secretlab.ca>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] spi_imx.c: TRIVIAL mx25 & mx35 SPI_VER is 0.7
Date: Thu, 23 Dec 2010 15:29:34 +0100 [thread overview]
Message-ID: <20101223142934.GU14221@pengutronix.de> (raw)
In-Reply-To: <1293102730-32528-2-git-send-email-richard.genoud@gmail.com>
On Thu, Dec 23, 2010 at 12:12:10PM +0100, Richard Genoud wrote:
> The check on cpu_is_mx25 and cpu_is_mx35 was made twice.
> This is obviously wrong.
obviously wrong but no wrong behaviour. Your patch only makes the code
consistent, but IMHO it doesn't qualify as a bugfix.
> Anyway, this patch won't change the previous behaviour which is
> SPI_IMX_VER_0_7 for mx25 and mx35.
This conflicts with
http://mid.gmane.org/1290589546-21662-1-git-send-email-u.kleine-koenig@pengutronix.de
which I prefer. The platform IDs have it correct (i.e.
imx25-cspi -> 0.7
imx31-cspi -> 0.4
imx35-cspi -> 0.7
)
Best regards
Uwe
>
> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
> ---
> drivers/spi/spi_imx.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/spi/spi_imx.c b/drivers/spi/spi_imx.c
> index 793ae99..96be9d1 100644
> --- a/drivers/spi/spi_imx.c
> +++ b/drivers/spi/spi_imx.c
> @@ -806,7 +806,7 @@ static int __devinit spi_imx_probe(struct platform_device *pdev)
> if (cpu_is_mx25() || cpu_is_mx35())
> spi_imx->devtype_data =
> spi_imx_devtype_data[SPI_IMX_VER_0_7];
> - else if (cpu_is_mx25() || cpu_is_mx31() || cpu_is_mx35())
> + else if (cpu_is_mx31())
> spi_imx->devtype_data =
> spi_imx_devtype_data[SPI_IMX_VER_0_4];
> else if (cpu_is_mx27() || cpu_is_mx21())
> --
> 1.7.1
>
>
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-12-23 14:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-23 11:12 [PATCH 1/2] spi_imx.c: CSPI3 irq is 0 on imx25 Richard Genoud
2010-12-23 11:12 ` [PATCH 2/2] spi_imx.c: TRIVIAL mx25 & mx35 SPI_VER is 0.7 Richard Genoud
2010-12-23 14:29 ` Uwe Kleine-König [this message]
2010-12-23 14:38 ` Richard Genoud
2010-12-23 19:03 ` Grant Likely
2010-12-23 19:01 ` Grant Likely
2010-12-23 18:59 ` [PATCH 1/2] spi_imx.c: CSPI3 irq is 0 on imx25 Grant Likely
2011-01-06 11:26 ` Richard Genoud
2011-01-07 14:26 ` [PATCH] spi_imx.c: correct the test on platform_get_irq() return value Richard Genoud
2011-01-07 15:26 ` Grant Likely
2011-01-07 16:41 ` Richard Genoud
2011-01-07 16:58 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101223142934.GU14221@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=dbrownell@users.sourceforge.net \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.genoud@gmail.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).