From: Paul Mundt <lethal@linux-sh.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
spi-devel-general@lists.sourceforge.net,
linux-sh@vger.kernel.org
Subject: Re: [PATCH 3/3] SPI: spi_sh_msiof: fix wrong address calculation, which leads to an Oops
Date: Sat, 22 Jan 2011 12:26:32 +0900 [thread overview]
Message-ID: <20110122032631.GA9453@linux-sh.org> (raw)
In-Reply-To: <20110121162743.GA7477@angua.secretlab.ca>
On Fri, Jan 21, 2011 at 09:27:43AM -0700, Grant Likely wrote:
> On Fri, Jan 21, 2011 at 04:56:47PM +0100, Guennadi Liakhovetski wrote:
> > NULL + <small offset> != NULL, but reading from that <small offset> address
> > is usually not a very good idea and often leads to problems, like kernel
> > Oopses in this case, easily reproducible by writing to an SD-card, used in
> > SPI mode.
> >
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>
> Applied, thanks. Since this is an oops fix, I'll push this one to
> Linus before the next -rc. The other two can go into linux-next for
> 2.6.39.
>
I haven't been following too closely, but this may also be a good -stable
candidate.
prev parent reply other threads:[~2011-01-22 3:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-21 15:56 [PATCH 3/3] SPI: spi_sh_msiof: fix wrong address calculation, which leads to an Oops Guennadi Liakhovetski
2011-01-21 16:27 ` Grant Likely
2011-01-22 3:26 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110122032631.GA9453@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=g.liakhovetski@gmx.de \
--cc=grant.likely@secretlab.ca \
--cc=linux-sh@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).