Re: [PATCH 1/3] SPI: spi_sh_msiof: cosmetic clean-up

[Paul Mundt <lethal@linux-sh.org>]

On Mon, Jan 24, 2011 at 10:26:55PM -0700, Grant Likely wrote:
> On Mon, Jan 24, 2011 at 10:02 PM, Simon Horman <horms@verge.net.au> wrote:
> > Surely this is a bug in diff. Or perhaps put more politely,
> > diff isn't smart enough to realise a) this is C and b) xxx: isn't
> > a valid function name in C.
> 
> Oh, perhaps.  But regardless, it is long-standing behaviour and the
> single space convention is widely used.  Nobody seems offended enough
> by it to go and change diff.  To see, just do:
> 
>         git grep '^ [a-zA-Z0-9_]*:'
> 
> If it were particularly ugly, or actively dangerous, then I'd be
> against this pattern, but it is neither and it noticeably improves
> diff readability.
> 
It's largely a personal preference thing. I personally don't care for the
leading spaces, and remove them whenever I encounter them. I know that
Magnus and some others like to use them however, so generally don't care
one way or the other. I assume general apathy has a lot to do with diff
not being fixed (note that this topic does come up from time to time,
where the general conclusion is that someone should probably do something
about it, at some point in time).