linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Feng Tang <feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Alan Cox <alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
	<spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	"dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
	<dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	"Du, Alek" <alek.du-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 4/4] spi/dw_spi: improve the interrupt mode with the batch ops
Date: Fri, 18 Mar 2011 21:03:25 +0800	[thread overview]
Message-ID: <20110318210325.02389634@feng-i7> (raw)
In-Reply-To: <20110318101310.57aa860f-Z/y2cZnRghHXmaaqVzeoHQ@public.gmane.org>

Hi Alan,

On Fri, 18 Mar 2011 18:13:10 +0800
Alan Cox <alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> wrote:

> On Fri, 18 Mar 2011 15:50:56 +0800
> Feng Tang <feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
> 
> > spi/dw_spi: improve the interrupt mode with the batch ops
> 
> Look sane to me - only question I have is should the patches have a
> 
> From: Alek Du <...>
> 
> on them ?


I've strongly requested Alek to make the patches himself, but he is too busy
with his project and just give me a .35 version dw_spi.c. So to get it 
quickly upstream, I manually separate his change, modify a little, combined
with mine, test, add some comments and his Signed-off.

I really don't know the "From: " matters so much, and thought the signed-off
and the cover-letter already claim the right credit :). Is is possible
for Grant to change the "From: " to Alek when he would like to merge these
patches?

Thanks,
Feng


------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d

  parent reply	other threads:[~2011-03-18 13:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-18  7:50 [PATCH 0/4] patch serie for dw_spi driver Feng Tang
     [not found] ` <1300434656-16870-1-git-send-email-feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2011-03-18  7:50   ` [PATCH 1/4] spi/dw_spi: unify the low level read/write routines Feng Tang
2011-03-18  7:50   ` [PATCH 2/4] spi/dw_spi: remove the un-necessary flush() Feng Tang
2011-03-18  7:50   ` [PATCH 3/4] spi/dw_spi: change poll mode transfer from byte ops to batch ops Feng Tang
2011-03-18  7:50   ` [PATCH 4/4] spi/dw_spi: improve the interrupt mode with the " Feng Tang
     [not found]     ` <1300434656-16870-5-git-send-email-feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2011-03-18 10:13       ` Alan Cox
     [not found]         ` <20110318101310.57aa860f-Z/y2cZnRghHXmaaqVzeoHQ@public.gmane.org>
2011-03-18 13:03           ` Feng Tang [this message]
2011-03-18 13:36             ` Alan Cox
2011-03-18 15:54             ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110318210325.02389634@feng-i7 \
    --to=feng.tang-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=alek.du-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).