linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Feng Tang <feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Jamie Iles <jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org>
Cc: "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
	<spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	"george-ofzTHo7+kyPpQY4QmZNtDQ@public.gmane.org"
	<george-ofzTHo7+kyPpQY4QmZNtDQ@public.gmane.org>
Subject: Re: dw_spi CS control/transfer modes
Date: Mon, 21 Mar 2011 10:06:42 +0800	[thread overview]
Message-ID: <20110321100642.24c326f9@feng-i7> (raw)
In-Reply-To: <20110318201135.GE3393-apL1N+EY0C9YtYNIL7UdTEEOCMrvLtNR@public.gmane.org>

Hi Jamie,

On Sat, 19 Mar 2011 04:11:35 +0800
Jamie Iles <jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org> wrote:

> Hi,
> 
> I have a platform with a DesignWare SSI and I'm trying to use the
> dw_spi block using a GPIO for the chip select to workaround the
> problem of CS changing and the device losing state (we have a SPI
> flash attached), and I've found that using interrupt driven
> transfers, reading the SPI flash results in very few interrupts from
> the controller and a sluggish system (and no data from the flash).
> 
> However, I've found that removing the conditional transfer mode
> setting (effectively reverting commit 052dc7c45 [spi/dw_spi:
> conditional transfer mode changes]) allows everything to work fine by
> keeping the transfer mode to transmit+receive.

What version of code are you using? The "cs_control" will be default to
NULL if "dw_spi_chip" as the controller data doesn't explicitly set it,
and then that piece of code won't be called.

Thanks,
Feng

> 
> Does anyone have any ideas on the best way to fix this?  That code
> must have been added for a reason so perhaps it's just a quirk on our 
> platform, but I'd be keen to know in what ways it's been tested
> before - afaict, no other in-tree platforms are using dw_spi with
> their own cs_control so it's difficult to know if perhaps these are
> all doing polled mode transfers.
> 
> Thanks,
> 
> Jamie
> 
> ------------------------------------------------------------------------------
> Colocation vs. Managed Hosting
> A question and answer guide to determining the best fit
> for your organization - today and in the future.
> http://p.sf.net/sfu/internap-sfd2d
> _______________________________________________
> spi-devel-general mailing list
> spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/spi-devel-general

------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d

  parent reply	other threads:[~2011-03-21  2:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-18 20:11 dw_spi CS control/transfer modes Jamie Iles
     [not found] ` <20110318201135.GE3393-apL1N+EY0C9YtYNIL7UdTEEOCMrvLtNR@public.gmane.org>
2011-03-21  2:06   ` Feng Tang [this message]
2011-03-21  8:14     ` Jamie Iles

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110321100642.24c326f9@feng-i7 \
    --to=feng.tang-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=george-ofzTHo7+kyPpQY4QmZNtDQ@public.gmane.org \
    --cc=jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org \
    --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).