From: "Du, Alek" <alek.du-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Alan Cox <alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
<spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [PATCH v2 3/4] spi/dw_spi: change poll mode transfer from byte ops to batch ops
Date: Thu, 31 Mar 2011 20:54:30 +0800 [thread overview]
Message-ID: <20110331205430.133b8497@dxy2> (raw)
In-Reply-To: <20110331105448.0f6d0bd4-Z/y2cZnRghHXmaaqVzeoHQ@public.gmane.org>
On Thu, 31 Mar 2011 17:54:48 +0800
Alan Cox <alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> wrote:
> On Wed, 30 Mar 2011 23:09:54 +0800
> Feng Tang <feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
>
> > From: Alek Du <alek.du-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> >
> > Current poll transfer will read/write one word, then wait till the
> > hw is non-busy, it's not efficient. This patch will try to read/write
> > as many words as permitted by hardware FIFO depth.
>
> This is reported to cause a regression on internal testing. It's one of
> that set of changes which seems to be breaking the touchscreen.
>
What's kind of touchscreen? Just do not understand how they are related.
You can see this patch only try to fill the TX FIFO more efficiently.
> Should we get that resolved before these go upstream ?
------------------------------------------------------------------------------
Create and publish websites with WebMatrix
Use the most popular FREE web apps or write code yourself;
WebMatrix provides all the features you need to develop and
publish your website. http://p.sf.net/sfu/ms-webmatrix-sf
next prev parent reply other threads:[~2011-03-31 12:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 15:09 [PATCH v2 0/4] patch serie for dw_spi driver Feng Tang
[not found] ` <1301497795-6924-1-git-send-email-feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2011-03-30 15:09 ` [PATCH v2 1/4] spi/dw_spi: unify the low level read/write routines Feng Tang
[not found] ` <1301497795-6924-2-git-send-email-feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2011-03-31 3:32 ` Grant Likely
2011-03-30 15:09 ` [PATCH v2 2/4] spi/dw_spi: remove the un-necessary flush() Feng Tang
[not found] ` <1301497795-6924-3-git-send-email-feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2011-03-31 3:32 ` Grant Likely
2011-03-30 15:09 ` [PATCH v2 3/4] spi/dw_spi: change poll mode transfer from byte ops to batch ops Feng Tang
[not found] ` <1301497795-6924-4-git-send-email-feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2011-03-31 3:32 ` Grant Likely
2011-03-31 9:54 ` Alan Cox
[not found] ` <20110331105448.0f6d0bd4-Z/y2cZnRghHXmaaqVzeoHQ@public.gmane.org>
2011-03-31 12:54 ` Du, Alek [this message]
2011-03-31 13:13 ` Grant Likely
2011-04-25 7:46 ` Feng Tang
2011-04-25 8:54 ` Du, Alek
2011-03-30 15:09 ` [PATCH v2 4/4] spi/dw_spi: improve the interrupt mode with the " Feng Tang
[not found] ` <1301497795-6924-5-git-send-email-feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2011-03-31 3:32 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110331205430.133b8497@dxy2 \
--to=alek.du-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).